-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
docs(tanstackstart): Add docs for distributed tracing #17735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JPeer264
wants to merge
1
commit into
master
Choose a base branch
from
jp/tanstack-distributed-tracing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+72
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
72 changes: 72 additions & 0 deletions
72
...form-includes/distributed-tracing/how-to-use/javascript.tanstackstart-react.mdx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| To connect server-side and client-side traces in TanStack Start, inject trace metadata into your HTML so the browser SDK can continue the trace started on the server. | ||
|
|
||
| In your root route (`routes/__root.tsx`), use `getTraceData()` to retrieve the current trace context and inject it as meta tags: | ||
|
|
||
| ```typescript {filename:routes/__root.tsx} | ||
| import type { ReactNode } from "react"; | ||
| import { | ||
| Outlet, | ||
| createRootRoute, | ||
| HeadContent, | ||
| Scripts, | ||
| } from "@tanstack/react-router"; | ||
| import { getTraceData } from "@sentry/tanstackstart-react"; | ||
|
|
||
| export const Route = createRootRoute({ | ||
| head: () => { | ||
| const traceData = getTraceData(); | ||
| const sentryMeta = Object.entries(traceData).map(([key, value]) => ({ | ||
| name: key, | ||
| content: value, | ||
| })); | ||
|
|
||
| return { | ||
| meta: [ | ||
| ...sentryMeta, | ||
| ], | ||
| }; | ||
| }, | ||
| component: RootComponent, | ||
| }); | ||
|
|
||
| function RootComponent() { | ||
| return ( | ||
| <RootDocument> | ||
| <Outlet /> | ||
| </RootDocument> | ||
| ); | ||
| } | ||
|
|
||
| function RootDocument({ children }: Readonly<{ children: ReactNode }>) { | ||
| return ( | ||
| <html> | ||
| <head> | ||
| <HeadContent /> | ||
| </head> | ||
| <body> | ||
| {children} | ||
| <Scripts /> | ||
| </body> | ||
| </html> | ||
| ); | ||
| } | ||
| ``` | ||
|
|
||
| This injects `sentry-trace` and `baggage` meta tags into the HTML. The browser SDK automatically reads these tags on page load and continues the server trace, connecting your full-stack traces in Sentry. | ||
|
|
||
| To get around possible [Browser CORS](https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS) issues, define `tracePropagationTargets` for client-side: | ||
|
|
||
| <Alert> | ||
|
|
||
| Note: port numbers are relevant for trace propagation and the origin. You may need to configure the `tracePropagationTargets` to ensure that traces are propagated across your services if they run on different ports. | ||
|
|
||
| </Alert> | ||
|
|
||
| ```typescript {filename:sentry.client.config.ts} | ||
| Sentry.init({ | ||
| dsn: "___PUBLIC_DSN___", | ||
| integrations: [Sentry.tanstackRouterBrowserTracingIntegration(router)], | ||
| tracesSampleRate: 1.0, | ||
| tracePropagationTargets: ["https://myproject.org", /^\/api\//], | ||
| }); | ||
| ``` | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The
Sentry.initcode snippet for TanStack Start uses an undefinedroutervariable, which will cause aReferenceErrorif copied directly.Severity: HIGH
Suggested Fix
Update the documentation to show the
Sentry.initcall within the correct file context, such assrc/router.tsxinside thegetRouter()function, where therouterconstant is defined. Alternatively, add a note explaining where theroutervariable comes from and that the snippet needs to be placed in the appropriate file whererouteris in scope.Prompt for AI Agent
Did we get this right? 👍 / 👎 to inform future reviews.