fix(a11y): render nav dropdowns inline for correct keyboard tab order#17681
Open
fix(a11y): render nav dropdowns inline for correct keyboard tab order#17681
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit dbc6c3c. Configure here.
sfanahata
approved these changes
May 8, 2026
Contributor
sfanahata
left a comment
There was a problem hiding this comment.
🤘 Looks great. Thank you for keeping on with this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

DESCRIBE YOUR PR
The Concepts and Manage nav dropdowns were rendered using ReactDOM.createPortal to
document.body, which placed their<a>tags at the bottom of the DOM — breaking keyboard tab order.Before
Keyboard users had to tab through the entire page before reaching dropdown items (in the video, you'll see it goes from "Concepts" → "API").
CleanShot.2026-05-07.at.19.45.44.mp4
After
Dropdowns render inline next to their trigger buttons, using
position: fixedto escape the parent'soverflow-x: autoclipping.CleanShot.2026-05-07.at.20.27.55.mp4
Tab now flows naturally: Concepts → Key Terms → Search → ... → API.
Also added Escape key function to exit open dropdowns.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: