Skip to content

feat: Add span name conventions for MCP server spans#377

Open
gggritso wants to merge 1 commit into
mainfrom
georgegritsouk/con-92-add-conventions-for-names-of-mcp-spans
Open

feat: Add span name conventions for MCP server spans#377
gggritso wants to merge 1 commit into
mainfrom
georgegritsouk/con-92-add-conventions-for-names-of-mcp-spans

Conversation

@gggritso
Copy link
Copy Markdown
Member

@gggritso gggritso commented May 14, 2026

We've been sorely missing a convention for how to make MCP server span names! This documents them, since I just ran into an issue. OTel has some newer guidelines here (e.g., they use gen_ai.tool.name) but I'm sticking to our current conventions, with the template lifted out of Python SDK.

Downstream, this would have affected how name is inferred for MCP server spans, but at this point we just use the transaction name, so it doesn't matter.

@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 14, 2026

CON-92

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 14, 2026

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Attributes

  • Add calculated performance scores by loewenheim in #355
  • Add rpc.response.status_code attribute by alexander-alderman-webb in #352
  • Add rpc.method attribute by alexander-alderman-webb in #351
  • Add app vitals start attributes by buenaflor in #353
  • Add process.runtime.engine.* attributes by chargome in #347

Other

  • Add span name conventions for MCP server spans by gggritso in #377

Bug Fixes 🐛

Attributes

  • Increase some PII values by loewenheim in #373
  • Change several deprecation statuses to normalize to align with ingestion paths by constantinius in #350

Other

  • (create) Replace angle brackets in file names by loewenheim in #356

Internal Changes 🔧

  • (gh) Remove myself from CODEOWNERS by lcian in #354
  • Bump vulnerable js packages by chargome in #359

🤖 This preview updates automatically when you update the PR.

@gggritso gggritso marked this pull request as ready for review May 14, 2026 01:25
@gggritso gggritso requested review from a team, Lms24, cleptric, mjq and nsdeschenes as code owners May 14, 2026 01:25
Copy link
Copy Markdown
Member

@betegon betegon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @gggritso! we'll catch up with OTEL and update things, but for now, let's stick to our convention as it's how the mcp sdk from anthropic works right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants