feat(attributes): add sentry.dsc.project_id as an attribute#358
feat(attributes): add sentry.dsc.project_id as an attribute#358constantinius wants to merge 5 commits into
Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
| * | ||
| * @example "12345" | ||
| */ | ||
| export const SENTRY_DSC_ROOT_PROJECT = 'sentry.dsc.root_project'; |
There was a problem hiding this comment.
Is this the best name for this attribute? @Dav1dde you might have some ideas about naming here, I think maybe we have a convention in relay already. What I know is that we use this as count_per_root_project in generic metrics, but maybe we can come up with a clearer name.
There was a problem hiding this comment.
I think project_id would fit, since we already have public_key which is also scoped to the DSC and therefor always the "root" -> the root is implied through the DSC.
But this is pretty confusing if one isn't familiar with DS(C)
There was a problem hiding this comment.
If the namespace dsc is enough to distinguish it then I'm fine with that. sentry.dsc.transaction also denotes the trace root transaction, so I guess this is fine here. Will change it to that.
There was a problem hiding this comment.
@Dav1dde done and also changed project ID type to integer, hope thats fine
Description
Required for Dynamic Sampling
Contributes to https://linear.app/getsentry/issue/TET-2341/write-root-transaction-and-project-onto-every-span-in-relay
PR Checklist
yarn testand verified that the tests pass.yarn generateto generate and format code and docs.If an attribute was added:
nextjs.function_id, notfunction_id)pii(i.e.maybeortrue. Usefalseonly for values that should never be scrubbed such as IDs)If an attribute was deprecated: