Skip to content

fix: Remove AGP 7.x R8 workaround #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
runningcode wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Remove AGP 7.x R8 workaround #1222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a217d06
fix: Remove AGP 7.x R8 workaround
runningcode May 22, 2026
f5b80a8
chore: Apply spotless formatting
runningcode May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,4 @@
buildscript {
dependencies { classpath("org.apache.commons:commons-compress:1.28.0") }
if (BuildPluginsVersion.AGP.substringBefore(".").toInt() < 8) {
// AGP 7.x has troubles with compileSdk 34 due to some R8 shenanigans, so we have to use a newer
// version of R* here
dependencies { classpath("com.android.tools:r8:8.11.18") }
}
}
buildscript { dependencies { classpath("org.apache.commons:commons-compress:1.28.0") } }

plugins {
alias(libs.plugins.kotlin) version BuildPluginsVersion.KOTLIN apply false
Expand Down
5 changes: 0 additions & 5 deletions plugin-build/src/test/kotlin/io/sentry/android/gradle/integration/BaseSentryPluginTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,6 @@ abstract class BaseSentryPluginTest(
// withPluginClasspath on the Gradle Runner.
$additionalBuildClasspath
classpath files($pluginClasspath)
if ("$androidGradlePluginVersion".split('\\.')[0].toInteger() < 8) {
// AGP 7.x has troubles with compileSdk 34 due to some R8 shenanigans, so we have to use a newer
// version of R* here
classpath 'com.android.tools:r8:8.11.18'
}
}
}

Expand Down
Loading