Open
Conversation
Reproduces the issue where requests library calls show incorrect/very short timing (< 1ms) in http.client spans with sentry-sdk 2.x. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
|
|
||
| # Make 3 requests, each should take ~1 second | ||
| for i in range(3): | ||
| response = requests.get(f"https://httpbin.org/delay/1") |
There was a problem hiding this comment.
Unnecessary f-string with no variable interpolation
Low Severity
The f-string f"https://httpbin.org/delay/1" on line 75 doesn't interpolate any variables, making the f prefix unnecessary. The loop variable i is available but not used in the URL. This is inconsistent with line 53, which correctly uses a plain string "https://httpbin.org/delay/1" for the same URL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reproduction for getsentry/sentry-python#5349
This reproduces the issue where
requestslibrary calls show incorrect/very short timing (< 1ms) inhttp.clientspans with sentry-sdk 2.x. In version 1.45, the spans correctly measured the actual HTTP request duration.How to run
Then hit
http://localhost:8000/orhttp://localhost:8000/multiple-requestsand check the traces in Sentry.Expected behavior
The
http.clientspans for requests tohttpbin.org/delay/1should show approximately 1000ms duration.Actual behavior
The
http.clientspans show impossibly short times (< 1ms) that don't reflect the real I/O time.🤖 Generated with Claude Code