Open
Conversation
Demonstrates bug where AggregateError subclasses with custom names are not detected as exception groups because the SDK checks error.name === "AggregateError" instead of error instanceof AggregateError.
3 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reproduction for getsentry/sentry-javascript#19014
This demonstrates the bug where
AggregateErrorsubclasses with customnameproperties are not detected as exception groups.The issue: The SDK checks
error.name === "AggregateError"instead oferror instanceof AggregateError, which causes customAggregateErrorsubclasses to lose theis_exception_groupflag and the "Related Exceptions" UI in Sentry.How to run
cd sentry-javascript/19014 npm install npm startExpected vs Actual
instanceof AggregateErroris_exception_groupAggregateErrortruetrue✓CustomAggregateErrortrueundefined✗Both should have
is_exception_group: truesince both are instances ofAggregateError.