fix(spans): Set sentry.trace.status on segment spans#6140
Open
mjq wants to merge 4 commits into
Open
Conversation
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 5e3588e. Configure here.
loewenheim
reviewed
Jun 25, 2026
loewenheim
left a comment
Contributor
There was a problem hiding this comment.
Is this a temporary measure? Otherwise the sentry.trace.status attribute should be added to conventions.
Member
Author
True, I'll add it (as well as |
Co-authored-by: Sebastian Zivota <loewenheim@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The product currently exposes
sentry.trace.statusto users (astrace.status). This is currently only set for v1 spans (extracted from the transaction's trace context'sstatusfield). Despite the name, it represents the transaction's status, not the whole trace.For backwards compatibility we have to expose this on v2 spans as well. This only makes sense on segment spans (but segment enrichment will copy the value to all children). The order of precedence is:
sentry.trace.statusattribute (v1 span)sentry.statusattribute (v1 span missing trace contextstatusfield)statusfield (v2 and OTel spans)I'm doing this in Relay because it:
🤖: Used Claude for the test cases