ref(spans): Gate description inference behind boolean flag#6115
Open
loewenheim wants to merge 2 commits into
Open
ref(spans): Gate description inference behind boolean flag#6115loewenheim wants to merge 2 commits into
loewenheim wants to merge 2 commits into
Conversation
loewenheim
commented
Jun 22, 2026
Comment on lines
+54
to
+55
| infer_ip: false, | ||
| infer_user_agent: false, |
Contributor
Author
There was a problem hiding this comment.
Actually, do we not want to do these for OTEL spans?
loewenheim
force-pushed
the
sebastian/infer-description-flag
branch
from
c51e659 to
8dab369
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8dab369. Configure here.
jjbayer
reviewed
Jun 23, 2026
| // By default, we only want to infer descriptions for V2 spans. | ||
| let default_settings = Settings { | ||
| infer_description: true, | ||
| ..Default::default() |
Member
There was a problem hiding this comment.
Why not have a manual Default impl with infer_description: true? Is there a use case where we want the field to be false by default?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow-up to #6112. That PR introduced a flag for name inference; this one does the same for description inference. It's not strictly speaking necessary because nothing goes wrong if we run the inference unnecessarily (it never overwrites existing descriptions), but I like it for symmetry and clarity.