feat(mobile-ui): Add slow, frozen, and total frames metrics#3473
Conversation
iker-barriocanal
left a comment
There was a problem hiding this comment.
Transactions have these values are measurements (see test). Spans also have measurements, are these values available in there? If not, can we reuse them?
@iker-barriocanal We do have them there, but the problem is that these values are associated with specific spans and we can't really propagate them from the transaction down. And in the current implementation they're sent in the span I see there's a method for extracting values from span data to span measurements here, would it be preferable if I pulled these values into that data structure? |
The difference between transaction measurements and span.measurements is that span measurements are not converted to metrics automatically, so even as a measurement we would need to define a metric in TL;DR yes, I would populate span.measurements as we do for |
jjbayer
left a comment
There was a problem hiding this comment.
@narsaynorath could you please update the PR description before merging? Distributions -> gauges, plus maybe mention measurements. Thanks!
Adds a new metric for collecting the `frames.delay` property from a span's `data` object in the Starfish Mobile UI module. I've added the tags that I think are necessary to query and filter for this metric, and they are common filters for other metrics in this config. Also noted is that the data is in the `data` object, similar to #3473 and thus I modified measurement extraction to copy this value over to span measurements.
Adds gauge metrics for slow, frozen, and total frames metrics for the Mobile UI Starfish module. The tags I've chosen are common and already applied to other mobile conditions.
The data source for these metrics come from the
dataproperty on spans, which I've extracted intomeasurementson spans.