Skip to content

chore(deps): update WORKFLOW-TEST-DEPENDENCY-DO-NOT-MERGE to v2.0.4 #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −1
Open

chore(deps): update WORKFLOW-TEST-DEPENDENCY-DO-NOT-MERGE to v2.0.4 #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,16 @@
- Validate PR - Skip validation for PRs with fewer than 100 lines changed, excluding common lock files (`Cargo.lock`, `yarn.lock`, `package-lock.json`, `Pipfile.lock`, etc.). Tiny PRs no longer go through the issue-discussion loop.
- Add validate-pr composite action for validating non-maintainer PRs against contribution guidelines ([#153](https://github.com/getsentry/github-workflows/pull/153))

### Fixes

- Updater - Select the first branch when multiple branches point at `HEAD` ([#165](https://github.com/getsentry/github-workflows/pull/165))

### Dependencies

- Bump WORKFLOW-TEST-DEPENDENCY-DO-NOT-MERGE from v2.0.0 to v2.0.4 ([#66](https://github.com/getsentry/github-workflows/pull/66))
- [changelog](https://github.com/getsentry/sentry-cli/blob/main/CHANGELOG.md#204)
- [diff](https://github.com/getsentry/sentry-cli/compare/2.0.0...2.0.4)

## 3.3.0

### Features
Expand Down
2 changes: 1 addition & 1 deletion updater/tests/sentry-cli.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
version = 2.0.0
version = 2.0.4
Copy link
Copy Markdown

@sentry sentry Bot May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Updating sentry-cli.properties to version 2.0.4 will break CI tests in workflow-tests.yml which hardcode an expectation for version 2.0.0.
Severity: HIGH

Suggested Fix

Update the hardcoded version assertions in .github/workflows/workflow-tests.yml. Change the lines $env:ORIGINAL_TAG | Should -Be "2.0.0" in the updater-pr-creation and updater-target-branch jobs to expect 2.0.4. Alternatively, revert the change to updater/tests/sentry-cli.properties as it is a test fixture intended to test updates from an older version.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: updater/tests/sentry-cli.properties#L1

Potential issue: The pull request updates the version in the test fixture
`updater/tests/sentry-cli.properties` from `2.0.0` to `2.0.4`. However, the CI workflow
tests in `.github/workflows/workflow-tests.yml` contain hardcoded assertions that expect
the `originalTag` to be `2.0.0`. After this change, the updater action will correctly
read the `originalTag` as `2.0.4`, causing the PowerShell assertion `"2.0.4" Should -Be
"2.0.0"` to fail in both the `updater-pr-creation` and `updater-target-branch` jobs.
This will break the build.

Also affects:

  • .github/workflows/workflow-tests.yml

Did we get this right? 👍 / 👎 to inform future reviews.

repo = https://github.com/getsentry/sentry-cli

This comment was marked as outdated.

Sign in to view

Copy link
Copy Markdown

@sentry sentry Bot Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The workflow tests have a hardcoded version check for 2.0.0, but the properties file is being updated to 2.0.4. This will cause the CI pipeline to fail.
Severity: HIGH

Suggested Fix

Update the hardcoded version string in the assertions within .github/workflows/workflow-tests.yml from 2.0.0 to 2.0.4 to match the change in the sentry-cli.properties file.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: updater/tests/sentry-cli.properties#L2

Potential issue: The version in `updater/tests/sentry-cli.properties` was updated from
`2.0.0` to `2.0.4`. The updater script reads this version and sets it as the
`ORIGINAL_TAG` output. However, the CI workflow tests in
`.github/workflows/workflow-tests.yml` contain hardcoded assertions that check if the
`ORIGINAL_TAG` is `2.0.0`. After this change, the `ORIGINAL_TAG` will be `2.0.4`,
causing the test assertions to fail because the value does not match the expected
`2.0.0`. This will cause the CI pipeline to fail when the pull request is merged.

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link
Copy Markdown

@sentry sentry Bot Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The version in sentry-cli.properties was updated to 2.0.4, but the corresponding hardcoded assertions in the workflow tests still expect 2.0.0, which will cause CI failures.
Severity: MEDIUM

Suggested Fix

Update the hardcoded version string in the assertions within .github/workflows/workflow-tests.yml from "2.0.0" to "2.0.4" to match the change in updater/tests/sentry-cli.properties.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: updater/tests/sentry-cli.properties#L2

Potential issue: The PR updates the version in `updater/tests/sentry-cli.properties` to
`2.0.4`, but the CI workflow tests in `.github/workflows/workflow-tests.yml` contain
hardcoded assertions that expect the original version to be `2.0.0`. When the workflow
runs, it will read the new version `2.0.4` and set the `originalTag` output to this
value. This will cause the test assertion `$env:ORIGINAL_TAG | Should -Be "2.0.0"` to
fail in both the `updater-pr-creation` and `updater-target-branch` jobs, breaking the CI
pipeline.

Copy link
Copy Markdown

@sentry sentry Bot Mar 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The CI workflow has a hardcoded assertion expecting version "2.0.0", but this PR updates the test dependency to "2.0.4", which will cause the test to fail.
Severity: MEDIUM

Suggested Fix

Update the hardcoded assertions in .github/workflows/workflow-tests.yml to expect the new version "2.0.4". Specifically, change the lines $env:ORIGINAL_TAG | Should -Be "2.0.0" to $env:ORIGINAL_TAG | Should -Be "2.0.4".

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: updater/tests/sentry-cli.properties#L2

Potential issue: The pull request updates the version in the test dependency file
`updater/tests/sentry-cli.properties` from `2.0.0` to `2.0.4`. However, the CI workflow
in `.github/workflows/workflow-tests.yml` contains hardcoded assertions that expect the
`originalTag` output to be `"2.0.0"`. After this PR is merged, the updater action will
read `2.0.4` as the original version, causing the assertion `$env:ORIGINAL_TAG | Should
-Be "2.0.0"` to fail. This will result in a CI failure on subsequent workflow runs
triggered after the merge.

Copy link
Copy Markdown

@sentry sentry Bot Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The version in updater/tests/sentry-cli.properties was updated, but the corresponding hardcoded version 2.0.0 in the CI test assertions in .github/workflows/workflow-tests.yml was not.
Severity: HIGH

Suggested Fix

Update the hardcoded version assertions in the updater-pr-creation and updater-target-branch test jobs within .github/workflows/workflow-tests.yml from "2.0.0" to "2.0.4" to match the new version in updater/tests/sentry-cli.properties.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: updater/tests/sentry-cli.properties#L2

Potential issue: The version in `updater/tests/sentry-cli.properties` was updated from
`2.0.0` to `2.0.4`, but the CI test assertions in `.github/workflows/workflow-tests.yml`
were not updated. The tests contain hardcoded assertions that check if the `originalTag`
is `2.0.0`. After this change is merged, the updater action will read `2.0.4` from the
properties file, causing the `originalTag` output to be `"2.0.4"`. Consequently, the
test assertion `$env:ORIGINAL_TAG | Should -Be "2.0.0"` will fail, breaking the
`updater-pr-creation` and `updater-target-branch` test jobs on every subsequent push.

Loading