Skip to content

fix(updater): Select first matching main branch#165

Open
jpnurmi wants to merge 3 commits intomainfrom
jpnurmi/test/sentry-cli-branch
Open

fix(updater): Select first matching main branch#165
jpnurmi wants to merge 3 commits intomainfrom
jpnurmi/test/sentry-cli-branch

Conversation

@jpnurmi
Copy link
Copy Markdown
Collaborator

@jpnurmi jpnurmi commented May 6, 2026 •
edited
Loading

sentry-cli currently has main and master pointing at the same HEAD, so the updater started emitting both names in mainBranch=main master output.

[-] update-dependency.output.writes output 1.97s (1.96s|9ms)
 Expected 'mainBranch=master' to be found in collection @('originalTag=0', 'latestTag=0.28.0', 'latestTagNice=v0.28.0', 'url=https://github.com/getsentry/sentry-cli', 'mainBranch=main master'), but it was not found.
 at $output | Should -Contain 'mainBranch=master', /Users/jpnurmi/Projects/sentry/github-workflows/updater/tests/update-dependency.Tests.ps1:223
 at _testOutput, /Users/jpnurmi/Projects/sentry/github-workflows/updater/tests/update-dependency.Tests.ps1:223
 at <ScriptBlock>, /Users/jpnurmi/Projects/sentry/github-workflows/updater/tests/update-dependency.Tests.ps1:232

@jpnurmi
test(updater): Update sentry-cli branch assertion
dcb3fe2 
sentry-cli currently has main and master pointing at the same HEAD, so
the updater emits both names in mainBranch output. Match that fixture
output instead of requiring master only.
@jpnurmi jpnurmi requested a review from vaind May 6, 2026 17:02
vaind
vaind requested changes May 7, 2026
View reviewed changes
Comment thread updater/tests/update-dependency.Tests.ps1 Outdated
@jpnurmi jpnurmi changed the title test(updater): Update sentry-cli branch assertion fix(updater): Select first matching main branch May 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026 •
edited
Loading

Warnings
⚠️ Could not load custom Dangerfile: .github/test-dangerfile-curl.js Error: ENOENT: no such file or directory, lstat '/github/workspace/.github/test-dangerfile-curl.js'

Generated by 🚫 dangerJS against ea0a1fb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vaind vaind vaind requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jpnurmi @vaind