Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@

- Sentry-CLI integration test action: support envelopes ([#58](https://github.com/getsentry/github-workflows/pull/58))

### Dependencies

- Bump TARGET-BRANCH-TEST-DO-NOT-MERGE from v2.0.0 to v2.0.4 ([#121](https://github.com/getsentry/github-workflows/pull/121))
- [changelog](https://github.com/getsentry/sentry-cli/blob/main/CHANGELOG.md#204)
- [diff](https://github.com/getsentry/sentry-cli/compare/2.0.0...2.0.4)

## 2.7.0

### Features
Expand Down
2 changes: 1 addition & 1 deletion updater/tests/sentry-cli.properties
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
version = 2.0.0
version = 2.0.4
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: A hardcoded version in a CI test assertion will cause the workflow to fail because the source version was updated.
Severity: MEDIUM

Suggested Fix

Update the hardcoded version string in the assertion in .github/workflows/workflow-tests.yml from '2.0.0' to '2.0.4' to match the new version in updater/tests/sentry-cli.properties.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.

Location: updater/tests/sentry-cli.properties#L1

Potential issue: The version in `updater/tests/sentry-cli.properties` was updated from
`2.0.0` to `2.0.4`. However, a CI test in `.github/workflows/workflow-tests.yml`
contains a hardcoded assertion `needs.updater-create-pr.outputs.originalTag == '2.0.0'`.
The `originalTag` output is derived from the version in the properties file, which will
now be `2.0.4`. This discrepancy will cause the `updater-test-outputs` CI job to fail on
every push after this pull request is merged, blocking future changes.

Also affects:

  • .github/workflows/workflow-tests.yml

Did we get this right? 👍 / 👎 to inform future reviews.

repo = https://github.com/getsentry/sentry-cli