Refactor talent functions to use CSC_GetTalentRank#96
Open
Gogo1951 wants to merge 1 commit intogetov:masterfrom
Open
Refactor talent functions to use CSC_GetTalentRank#96Gogo1951 wants to merge 1 commit intogetov:masterfrom
Gogo1951 wants to merge 1 commit intogetov:masterfrom
Conversation
Refactor talent-related functions for consistency and clarity, ensuring all functions use CSC_GetTalentRank for retrieving talent ranks instead of select. This improves readability and maintainability of the code.
Contributor
Author
|
Hey @getov you still maintaining this or is it dead? Happy to take it over if you're done, but if you don't respond I'm going to fork it and fix it as a new add-on. |
Owner
|
It is not "dead'. I am just not actively developing it anymore. Only fixing major issues caused by API changes. |
|
@getov well there are contributors that are helpful so if you don't mind just reviewing the changes and approving the PR. Here is the issue that and explanation how i solved it for myself #94. If you are not bothered to fix "minor" problems then rely on the community when they offer to help with that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor talent-related functions for consistency and clarity, ensuring all functions use CSC_GetTalentRank for retrieving talent ranks instead of select. This improves readability and maintainability of the code.