ci: a release over a red tree drafts itself - #24
Merged
Conversation
Branch protection covers merging; gh release create goes straight to the world with nothing reviewing it. Since it cannot be prevented it gets reverted: on release publish the tagged commit's checks are read, and a tag whose commit is not green moves to draft with an issue naming the counts. It drafts rather than deletes, because one false positive would otherwise destroy a legitimate release and its tag. Greenhouse evidence/0171, measured in both directions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch protection covers merging.
gh release creategoes straight to the world with nothing reviewing it, and there is no release protection the way there is branch protection.Since it cannot be prevented it gets reverted: on
release: publishedthe tagged commit's checks are read, and a tag whose commit is not green moves to draft with an issue naming the counts.It drafts rather than deletes — one false positive would destroy a legitimate release and its tag. Greenhouse
evidence/0171, measured in both directions onapp-runtime: red tree drafts itself, green stays.