fix: require milpa/command ^0.7, the only range this package can run in - #20
Merged
Conversation
PluginOperations imports Milpa\Command\Effect\Subject and uses it fifteen times. That class does not exist before command v0.7.0, while composer.json declared ^0.6 as acceptable. Verified by execution rather than by reading the constraint: with command v0.6.0 resolved, composer installs happily and calling operations() dies on Class "Milpa\Command\Effect\Subject" not found. The declaration was false, not merely stale. The constraint narrows rather than widens, which is the point — it turns a silent runtime death into a composer-time conflict. Suite green at 391 tests. This is the same defect devtools v0.14.0 shipped with, fixed in v0.14.1. Refs greenhouse decisions/0025.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PluginOperationsimportsMilpa\Command\Effect\Subjectand uses it fifteen times. That class does not exist before command v0.7.0, whilecomposer.jsondeclared^0.6acceptable.Verified by execution, not by reading the constraint:
The declaration was false, not merely stale.
The constraint narrows rather than widens — that is the point: it turns a silent runtime death into a composer-time conflict. Suite green at 391 tests / 1085 assertions.
Same defect
devtoolsv0.14.0 shipped with, fixed in v0.14.1. Refs greenhousedecisions/0025.