Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a shared Flutter integration-test harness for VPN connect/disconnect smoke coverage across desktop platforms, and wires up a new Windows CI smoke step that installs the Windows build, validates service/token readiness, runs the UI smoke test, then uninstalls for cleanup.
Changes:
- Refactors the existing Linux connect/disconnect smoke test to reuse a shared
connect_smoke_harness.dart. - Adds a new Windows connect/disconnect smoke integration test that uses the shared harness.
- Adds a Windows GitHub Actions step plus a PowerShell script to install via the produced installer, run the Flutter smoke test (optionally with IP-change validation), and uninstall.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| integration_test/vpn/windows_connect_smoke_test.dart | Adds a Windows desktop integration test that runs the shared connect/disconnect harness. |
| integration_test/vpn/linux_connect_smoke_test.dart | Replaces the prior inline Linux smoke logic with a call into the shared harness. |
| integration_test/vpn/connect_smoke_harness.dart | Introduces the shared connect/disconnect smoke harness (including optional public IP-change validation). |
| .github/workflows/build-windows.yml | Adds a Windows CI step to run the installer-based smoke script and integration test. |
| .github/scripts/windows_connect_smoke.ps1 | Implements installer-based setup + service/token waits + flutter test invocation + cleanup uninstall. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
.github/workflows/build-windows.yml
Outdated
Comment on lines
+186
to
+195
| - name: Windows installer + UI connect/disconnect integration | ||
| shell: pwsh | ||
| timeout-minutes: 20 | ||
| env: | ||
| FULL_INSTALLER_NAME: ${{ inputs.installer_base_name }}${{ inputs.build_type != 'production' && format('-{0}', inputs.build_type) || '' }} | ||
| run: | | ||
| ./.github/scripts/windows_connect_smoke.ps1 ` | ||
| -UseInstaller ` | ||
| -InstallerPath "$env:FULL_INSTALLER_NAME.exe" ` | ||
| -EnableIpCheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a shared connect_smoke_harness.dart for Linux and Windows tests, and adds a Windows CI smoke step that installs the build, waits for service/token readiness, runs Flutter connect/disconnect smoke (optionally checks IP change), then uninstalls for cleanup.