add explicit credentials to AzureMLAssetDataset#161
Draft
AlexandreOuellet wants to merge 12 commits intogetindata:developfrom
Draft
add explicit credentials to AzureMLAssetDataset#161AlexandreOuellet wants to merge 12 commits intogetindata:developfrom
AlexandreOuellet wants to merge 12 commits intogetindata:developfrom
Conversation
catalog already has a __contains__ method, which ensures that the dataset name (or input/output name in some cases) fits either with a known dataset, or a dataset pattern, which enables it to work with dataset factory
…alog (for dataset factories)
|
|
||
| catalog.add(dataset_name, dataset, replace=True) | ||
|
|
||
| for input in pipeline.all_inputs(): |
Author
There was a problem hiding this comment.
This is where the main difference happens. Instead of looping over the catalog, we loop over the pipeline's input, and then verify within the catalog if we have that input. That way, it gives a chance for the dataset factories to be instantiated, and they are then handled as usual (call as_remote(), etc...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing #160
Essentially, I explicitly inject the azureml's credential with after_context_created into a azureml key, then I used this key in the AzureMLAssetDataset as "credentials".