#12571 , #12573 Support of distinct search-typename in WMS layers and way to edit urls of layers - #12802
Open
Binabh wants to merge 3 commits into
Open
Conversation
This was
linked to
issues
Aug 14, 2026
tdipisa
requested review from
offtherailz
and removed request for
allyoucanmap
August 14, 2026 13:33
offtherailz
requested changes
Aug 18, 2026
offtherailz
left a comment
Member
There was a problem hiding this comment.
Hi, some feedback from the UI point of view:
- Validation is missing on the layer URL and on the WFS URL/typeName fields (currently only the layer name is validated). The layer URL should go through the same validation as the layer name, and the WFS fields as well — the typeName could be validated with a DescribeFeatureType call, which would also give us the field refresh (see below). Note that with no validation an empty value is accepted: since
getSearchUrlfalls back to the layer URL, an empty WFS URL silently sends WFS requests to the WMS endpoint. GeoServer answers those on/wmstoo, so nothing looks broken, but it breaks as soon as the WFS lives on a different endpoint or host. - Fields stay saved once they have been downloaded, even if the layer changed completely: they are not reloaded when the typeName (or the layer name) changes, and the stale list is persisted on the layer. This is a pre-existing behaviour that may affect bbox and other items too, so it may be worth a separate issue. On reload I would keep the merge as it is: fields with the same name keep their customizations, fields that no longer exist disappear, and the dedicated button is there for whoever wants to drop the customizations — otherwise renaming a layer or changing an attribute means rewriting everything.
- When you turn the WFS panel off and on again, the typeName is recreated with the layer name while the URL is left empty. Both are actually rewritten from defaults, so a custom typeName is silently replaced by the layer name. Could we use the same DescribeLayer request to retrieve the WFS URL (and typeName) when re-enabling the panel? Please note that the current merge keeps the existing
searchon top of the detected one, so it has to be reversed for an explicit user action, and we should handle servers that do not support DescribeLayer by simply leaving the field empty.
Open
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR covers two functionalities of letting user change layer URL and WFS linked service for WMS Layers
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#12571 #12573
What is the new behavior?
User is able to change URLs and WFS linked service and it properly reflects on network calls.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)