Replace lifecycle functions with UNSAFE_ versions#12502
Open
jna4k wants to merge 1 commit into
Open
Conversation
…ith UNSAFE_componentWillReceiveProps and UNSAFE_componentWillUpdate
Open
Member
|
@jna4k thank you for opening that. PSC members will check the issue definition and this asap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces componentWillReceiveProps and componentWillUpdate with the UNSAFE_componentWillReceiveProps and UNSAFE_componentWillUpdate lifecycle functions.
This change is necessary is to make sure that our legacy components will work with react 17+ see https://legacy.reactjs.org/blog/2018/03/27/update-on-async-rendering.html
This change was done as a part of the React 19 upgrade, see #12500
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#12500
We are currently using the componentWillReceiveProps and componentWillUpdate lifecycle functions.
What is the new behavior?
We will no longer use the componentWillReceiveProps and componentWillUpdate lifecycle functions, and will instead us.e the UNSAFE_componentWillReceiveProps and UNSAFE_componentWillUpdate versions that are compatible with react 17+
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information