COG layers are loading data even if not visible #12360#12488
Open
rowheat02 wants to merge 1 commit into
Open
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR prevents hidden COG layers from loading TIFF data in the background.
COG layers use ol/source/GeoTIFF, which initializes TIFF metadata when the source is constructed. Because MapStore was creating the GeoTIFF source even when visibility:false, hidden COG layers could still trigger HTTP range requests.
The fix delays COG OpenLayers layer/source creation until the layer becomes visible.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#12360
What is the new behavior?
COG layer will not request for data when it is in hidden state.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information