Skip to content

Remove reqwest default tls feature#58

Open
flosse wants to merge 2 commits into
georust:masterfrom
slowtec:remove-reqwest-default-tls-feature
Open

Remove reqwest default tls feature#58
flosse wants to merge 2 commits into
georust:masterfrom
slowtec:remove-reqwest-default-tls-feature

Conversation

@flosse

@flosse flosse commented Aug 29, 2022

Copy link
Copy Markdown
Contributor
  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

Comment thread src/opencage.rs
Comment thread Cargo.toml
@lnicola

lnicola commented Feb 13, 2023

Copy link
Copy Markdown
Member

r? @urschrei

@urschrei

Copy link
Copy Markdown
Member

This will need a rebase when #57 merges, right?

@michaelkirk

Copy link
Copy Markdown
Member

The chrono work was just merged in #60 so this will at least need a rebase.

But also... what is this PR doing? Is it disabling TLS? Why would we want that?

@michaelkirk

Copy link
Copy Markdown
Member

Oh, I think I understand.

We want people to be able to choose their tls backend, which are already exposed by geocoding features:

[features]
default = ["reqwest/default"] # this builds default-tls
rustls-tls = ["reqwest/rustls-tls"] # this builds rust-tls

But we were erroneously (redundantly) declaring that reqwest always builds default-tls, so there was no way to use only rust-tls without this PR. Is that right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants