Skip to content

update dependencies, fix all clippy lints#48

Open
elwerene wants to merge 6 commits into
georust:masterfrom
elwerene:update-dependencies
Open

update dependencies, fix all clippy lints#48
elwerene wants to merge 6 commits into
georust:masterfrom
elwerene:update-dependencies

Conversation

@elwerene

Copy link
Copy Markdown
Contributor

No description provided.

@urschrei

Copy link
Copy Markdown
Member

lgtm.

@urschrei

Copy link
Copy Markdown
Member

bors try

bors Bot added a commit that referenced this pull request Aug 11, 2021
@michaelkirk

Copy link
Copy Markdown
Member

I think CI is blocked on #49

Comment thread src/geoadmin.rs Outdated
@elwerene

Copy link
Copy Markdown
Contributor Author

cargo test does not go through on my machine, but also not in master :/

@urschrei

Copy link
Copy Markdown
Member

Hi @elwerene, I've probably caused some conflicts in Cargo.toml – apologies. If you rebase against master and accept them your PR should pass tests and we can merge.

@bors

bors Bot commented Aug 17, 2021

Copy link
Copy Markdown
Contributor

try

Timed out.

@elwerene

Copy link
Copy Markdown
Contributor Author

@urschrei I just fixed the conflicts

@elwerene elwerene requested a review from michaelkirk August 18, 2021 07:07
Comment thread src/geoadmin.rs Outdated
@michaelkirk

Copy link
Copy Markdown
Member

bors try

bors Bot added a commit that referenced this pull request Aug 18, 2021
@bors

bors Bot commented Aug 18, 2021

Copy link
Copy Markdown
Contributor

try

Build succeeded:

@elwerene

Copy link
Copy Markdown
Contributor Author

bors try

@bors

bors Bot commented Aug 18, 2021

Copy link
Copy Markdown
Contributor

🔒 Permission denied

Existing reviewers: click here to make elwerene a reviewer

@lnicola

lnicola commented Aug 18, 2021

Copy link
Copy Markdown
Member

bors try

@bors

bors Bot commented Aug 18, 2021

Copy link
Copy Markdown
Contributor

🔒 Permission denied

Existing reviewers: click here to make lnicola a reviewer

@urschrei

Copy link
Copy Markdown
Member

Existing reviewers: click here to make lnicola a reviewer

try again!

@lnicola

lnicola commented Aug 18, 2021

Copy link
Copy Markdown
Member

bors try

bors Bot added a commit that referenced this pull request Aug 18, 2021
@bors

bors Bot commented Aug 18, 2021

Copy link
Copy Markdown
Contributor

try

Build succeeded:

@michaelkirk

Copy link
Copy Markdown
Member

Hi @elwerene - sorry that this sat so long. Can you explain why you made the most recent change? f71c2a1

@lnicola

lnicola commented Nov 29, 2021

Copy link
Copy Markdown
Member

Is it rust-lang/cargo#3494 again? 😄

@elwerene

Copy link
Copy Markdown
Contributor Author

No, I accidently set the wrong feature before and it wasn't possible to use rustls without defaultls. Now it's just an update without changing the tls feature behavior.
maybe it's the mentioned cargo issue? I'm too tired to understand it atm :)
Maybe tomorrow..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants