Integrate R2 (or similar S3 apis)#77
Open
FireMario211 wants to merge 11 commits into
Open
Conversation
Member
|
By the way, wait for #78 to merge, it simplifies storage.rs and you can implement a backend for it. |
Member
|
Forgot to mention that it's merged now. |
dankmeme01
marked this pull request as ready for review
July 18, 2026 17:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new column:
managed_download_link, which is used to redirect downloads and is prioritized overdownload_link. Once a mod is approved, the index asynchronously re-uploads the .geode file to the S3 storage, if it is enabled, and updatesmanaged_download_link. This lets us serve downloads from the fast and reliable Cloudflare R2 storage and not worry about mods becoming undownloadable if someone messes up their repository or such.There is a migration that runs every time the server is started and uploads mods to S3 that do not have the managed link set. The criteria for a specific mod version to be auto migrated to S3 upon startup are:
This PR also has some unrelated refactors, such as small idiomatic Rust improvements and the use of a single
reqwest::Clientin the entire index instead of creating a new client per http request.