Remove unnecessary startup deferral in sensor async_added_to_hass#17
Draft
Remove unnecessary startup deferral in sensor async_added_to_hass#17
async_added_to_hass#17Conversation
Co-authored-by: gensyn <36128035+gensyn@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix sensor update deferral in async_added_to_hass
Remove unnecessary startup deferral in sensor Mar 15, 2026
async_added_to_hass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initial entity update in
async_added_to_hasswas deferred untilEVENT_HOMEASSISTANT_STARTEDwhen HA wasn't fully running. The deferral is unnecessary —async_updateis fast (date arithmetic + todo list sync) and doesn't block startup. The deferred path also usedasyncio.run_coroutine_threadsafe, which is designed for cross-thread scheduling and is incorrect when called from within the event loop.Changes
sensor.py: Replace theCoreState.runningconditional andasync_listen_once/run_coroutine_threadsafedeferral with a directawait self.async_update()call. Remove now-unused imports:asyncio,CoreState,EVENT_HOMEASSISTANT_STARTED.Before:
After:
test/test_sensor.py: AddTestTaskTrackerSensorAddedToHasscovering: immediate update call, update called regardless ofhass.state, state restoration, event listener registration, and absence ofasync_listen_onceregistration.Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.