Andriod server#2313
Open
Charlie-Zheng wants to merge 6 commits intogenshinsim:mainfrom
Open
Conversation
Charlie-Zheng
force-pushed
the
andriod_server
branch
2 times, most recently
from
f62f098 to
0c5367c
Compare
Collaborator
Author
|
This is ready for review |
srliao
reviewed
Feb 12, 2025
|
|
||
| func (s *Server) Progress() map[string]Progress { | ||
| progress := make(map[string]Progress) | ||
| for id, wk := range s.pool { |
Contributor
There was a problem hiding this comment.
s.pool and more specifically, the worker held by s.pool ideally should not be accessed like this. Although you're not doing any write operations here so it probably won't cause any problem, this is still non-ideal. s.pool is not safe for concurrent accesses.
haven't thought about what a better solution would be. possibly some kind of concurrency safe read only method on workers to get the info you want?
Collaborator
Author
There was a problem hiding this comment.
Should I run s.Lock() before calling progress?
Charlie-Zheng
force-pushed
the
andriod_server
branch
from
fb0f46c to
aa86701
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a build for andriod server apk.