fix: restore VSCode test discovery and make GPU isolation opt-in#605
Draft
planetf1 wants to merge 1 commit intogenerative-computing:mainfrom
Draft
fix: restore VSCode test discovery and make GPU isolation opt-in#605planetf1 wants to merge 1 commit intogenerative-computing:mainfrom
planetf1 wants to merge 1 commit intogenerative-computing:mainfrom
Conversation
- Add --isolate-heavy CLI flag for explicit GPU isolation - Add @pytest.mark.requires_gpu_isolation marker - Rewrite pytest_collection_finish with 4-guard architecture - Fix test discovery (pytest --collect-only now works instantly) - Apply markers to all 4 heavy GPU test files - Fix failure propagation from subprocesses - Update documentation for new markers and flags Fixes generative-computing#604
Contributor
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Restore VSCode test discovery and make GPU isolation opt-in
Fixes #604
Type of PR
Description
Issue #604 reported three critical problems: (1) VSCode test discovery broken -
pytest --collect-onlywould hang, (2) Silent test skipping - 400+ tests silently skipped due to automatic GPU isolation, (3) Hidden failures - test failures masked by hardpytest.exit()calls.Solution: Implemented 4-guard architecture for opt-in GPU isolation:
--collect-only(fixes VSCode)--isolate-heavyflag orCICD=1setChanges:
--isolate-heavyCLI flag for explicit GPU process isolation@pytest.mark.requires_gpu_isolationmarker (applied to 4 heavy GPU test files)pytest_collection_finishwith 4-guard architectureimport warnings,_collect_heavy_ram_modules())Files: 9 files changed, 115 insertions, 75 deletions
Testing
Additional Validation:
pytest --collect-only)^^ DRAFT whilst verifying remaining areas