Conversation
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
|
We will have to also update our github settings to require 3.13 passing and not require 3.10 status check. Will update them immediately before merging this PR. |
ajbozarth
left a comment
There was a problem hiding this comment.
As a minimal first step this looks ok, I didn't test it though.
As a follow up I'd suggest working with Bob or Claude to track down instances in our code where we may have made compromises in implementation to support 3.10 and update or remove them.
That's fair. When I searched, I found two instances that were in examples, but they didn't make any real difference in the code (just caused us to use enums instead of a list of literals). I will do a search with claude and report back. |
|
Asked claude for suggestions and implemented them. Tests still pass. Thank you for the suggestion! |
ajbozarth
left a comment
There was a problem hiding this comment.
LGTM, we can include any other improvements as we find them :)
(only reviewed code, did not test)
|
Was doing some development and ran into this warning when running ruff: If I remember correctly when I was adding global lint I tried to remove this to get rid of the warning and it cause CI to fail because it was needed for 3.10 but removed for 3.11 and later. You should see if we can safely remove |
9bbe9f3 to
fae3a4d
Compare
Misc PR
Type of PR
Description
Testing