feat: carry reasoning across turns with per-backend replay policy#1374
Open
AngeloDanducci wants to merge 2 commits into
Open
feat: carry reasoning across turns with per-backend replay policy#1374AngeloDanducci wants to merge 2 commits into
AngeloDanducci wants to merge 2 commits into
Conversation
Signed-off-by: AngeloDanducci <angelo.danducci.ii@ibm.com>
ajbozarth
reviewed
Jul 13, 2026
ajbozarth
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the full diff and traced the capture → _parse → policy → serialize path. Solid, conservative change — no correctness blockers. All 72 new/changed tests pass locally. Action items below.
Before merge
- Complete the live-model verification. The e2e test (
test_reasoning_replay_e2e.py) is env-gated and CI-skipped, so nothing in CI exercisesreasoning_content/thinkingagainst a real endpoint. The PR body's own "still needs verification" note stands — this is the one thing that would catch a provider rejecting the injected wire key. - Tighten the PR body to say this lands the consensus rule only. The title says "per-backend replay policy" and
provideris a parameter, but the policy is currently provider-agnostic (provideris unused, documented as a reserved hook). The divergent contracts from #1201's table — DeepSeek hard-400 without tools, Anthropic signed blocks — are not implemented here. State that explicitly so reviewers/users don't assume DeepSeek/Anthropic are covered.
Non-blocking
- HF chat path is silently uncovered (see inline comment). Functionally fine given HF's capture gap, but a one-liner would prevent a future reader assuming coverage.
Verified separately
should_replay_reasoningreturns exactlylen(messages)flags, so thezipin each backend never truncates.- The adjacency check correctly maps to "this turn issued a tool call" —
_acall_toolsappendsToolMessage(role="tool")right after the tool-issuing turn. - Default
replay_reasoning=Falsepreserves historical behavior. - Real OpenAI Chat Completions never populates
thinking, so the non-standard key is never sent there.
Signed-off-by: AngeloDanducci <angelo.danducci.ii@ibm.com>
Contributor
Author
|
|
Contributor
|
This LGTM as far as Claude reviews go , but I'd prefer to defer final approval to @jakelorocco after he returns since this is a decently sized change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Fixes #1201
Description
Carry reasoning across turns with per-backend replay policy for better thinking handling.
The policy is currently provider-agnostic (provider is unused, documented as a reserved hook). The divergent contracts from #1201 table — DeepSeek hard-400 without tools, Anthropic signed blocks — are not implemented here.
Testing
Attribution
Adding a new component, requirement, sampling strategy, or tool?
If your PR adds or modifies one of the types below, check the matching box. A checklist of type-specific review items will be posted as a comment.
NOTE: Please ensure you have an issue that has been acknowledged by a core contributor and routed you to open a pull request against this repository. Otherwise, please open an issue before continuing with this pull request.