Skip to content

fix: change hallucination detection tests to accept differences in explanation#1059

Open
jakelorocco wants to merge 2 commits into
generative-computing:mainfrom
jakelorocco:fix/hallucination-detection
Open

fix: change hallucination detection tests to accept differences in explanation#1059
jakelorocco wants to merge 2 commits into
generative-computing:mainfrom
jakelorocco:fix/hallucination-detection

Conversation

@jakelorocco
Copy link
Copy Markdown
Contributor

@jakelorocco jakelorocco commented May 11, 2026

Misc PR

Type of PR

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Description

Made the test more permissive in accepting output. Also fixed one unnecessary warning from the open ai backend.

New versions of the tests pass both locally on an apple silicon mac and on a linux machine:

test/stdlib/components/intrinsic/test_rag.py::test_hallucination_detection PASSED                                                              [ 50%]
test/stdlib/components/intrinsic/test_rag.py::test_hallucination_detection_resolve PASSED                                                      [100%]

Testing

  • Tests added to the respective file if code was changed
  • New code has 100% coverage if code as added
  • Ensure existing tests and github automation passes (a maintainer will kick off the github automation when the rest of the PR is populated)

Attribution

  • AI coding assistants used

…planation

Signed-off-by: Jake LoRocco <jake.lorocco@ibm.com>
Signed-off-by: Jake LoRocco <jake.lorocco@ibm.com>
@github-actions github-actions Bot added the bug Something isn't working label May 11, 2026
@github-actions
Copy link
Copy Markdown
Contributor

The PR description has been updated. Please fill out the template for your PR to be reviewed.

@jakelorocco jakelorocco marked this pull request as ready for review May 12, 2026 12:08
@jakelorocco jakelorocco requested a review from a team as a code owner May 12, 2026 12:08
@jakelorocco jakelorocco linked an issue May 12, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: hallucination detection tests

1 participant