Skip to content

Replace tiny-keccak with sha3::Keccak256#1060

Merged
0xh3rman merged 1 commit intomainfrom
remove-tiny-keccak
Apr 7, 2026
Merged

Replace tiny-keccak with sha3::Keccak256#1060
0xh3rman merged 1 commit intomainfrom
remove-tiny-keccak

Conversation

@0xh3rman
Copy link
Copy Markdown
Collaborator

@0xh3rman 0xh3rman commented Apr 7, 2026

Summary

  • Remove tiny-keccak direct dependency, use sha3::Keccak256 which was already a dependency
  • Add hex to gem_hash
  • Add keccak256 unit test

Test plan

  • cargo clippy -p gem_hash -- -D warnings passes
  • just test gem_hash passes

sha3 is already a dependency, so tiny-keccak was redundant for keccak256.
Add hex to gem_hash and add keccak256 unit test.
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the tiny-keccak dependency with sha3 in the gem_hash crate, simplifies the keccak256 implementation, and adds unit tests. It also updates the socket2 dependency version across the workspace. Feedback suggests improving the unit tests by comparing raw byte arrays instead of hex-encoded strings to enhance performance and clarity.

@0xh3rman 0xh3rman merged commit 094c865 into main Apr 7, 2026
5 checks passed
@0xh3rman 0xh3rman deleted the remove-tiny-keccak branch April 7, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant