Replace tiny-keccak with sha3::Keccak256#1060
Merged
Conversation
sha3 is already a dependency, so tiny-keccak was redundant for keccak256. Add hex to gem_hash and add keccak256 unit test.
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces the tiny-keccak dependency with sha3 in the gem_hash crate, simplifies the keccak256 implementation, and adds unit tests. It also updates the socket2 dependency version across the workspace. Feedback suggests improving the unit tests by comparing raw byte arrays instead of hex-encoded strings to enhance performance and clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tiny-keccakdirect dependency, usesha3::Keccak256which was already a dependencyhextogem_hashkeccak256unit testTest plan
cargo clippy -p gem_hash -- -D warningspassesjust test gem_hashpasses