Skip to content

fix: do not retry errors with code timeout from webdriver#41

Merged
shadowusr merged 1 commit intomasterfrom
users/shadowusr/TESTPLANE-983
May 4, 2026
Merged

fix: do not retry errors with code timeout from webdriver#41
shadowusr merged 1 commit intomasterfrom
users/shadowusr/TESTPLANE-983

Conversation

@shadowusr
Copy link
Copy Markdown
Member

@shadowusr shadowusr commented May 2, 2026

What's done?

Added a check to NOT retry errors with code timeout from driver.

Motivation:

  1. User sets page load timeout=2s
  2. Makes a request to a page that loads indefinitely
  3. We do 1 + 3 tries under the hood, resulting in 8s spent on this command instead of 2s the user declared

What timeout code means is described in the spec: https://w3c.github.io/webdriver/#dfn-timeout

In practice, we are interested in this for navigation commands, timeouts related to: script execution, timeouts to the driver itself, etc. are not affected by this change.

My change disables timeouts specifically for a case when a driver returns the timeout code, signaling it failed to complete requested operation on time.

Tested on: chrome 138, firefox 145, safari 26.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 2, 2026

Open in StackBlitz

@testplane/devtools

npm i https://pkg.pr.new/gemini-testing/webdriverio/@testplane/devtools@41

eslint-plugin-wdio

npm i https://pkg.pr.new/gemini-testing/webdriverio/eslint-plugin-wdio@41

@wdio/allure-reporter

npm i https://pkg.pr.new/gemini-testing/webdriverio/@wdio/allure-reporter@41

@wdio/appium-service

npm i https://pkg.pr.new/gemini-testing/webdriverio/@wdio/appium-service@41

@wdio/browser-runner

npm i https://pkg.pr.new/gemini-testing/webdriverio/@wdio/browser-runner@41

@wdio/browserstack-service

npm i https://pkg.pr.new/gemini-testing/webdriverio/@wdio/browserstack-service@41

@wdio/cli

npm i https://pkg.pr.new/gemini-testing/webdriverio/@wdio/cli@41

@wdio/concise-reporter

npm i https://pkg.pr.new/gemini-testing/webdriverio/@wdio/concise-reporter@41

@testplane/wdio-config

npm i https://pkg.pr.new/gemini-testing/webdriverio/@testplane/wdio-config@41

@wdio/cucumber-framework

npm i https://pkg.pr.new/gemini-testing/webdriverio/@wdio/cucumber-framework@41

@wdio/dot-reporter

npm i https://pkg.pr.new/gemini-testing/webdriverio/@wdio/dot-reporter@41

@wdio/firefox-profile-service

npm i https://pkg.pr.new/gemini-testing/webdriverio/@wdio/firefox-profile-service@41

@wdio/globals

npm i https://pkg.pr.new/gemini-testing/webdriverio/@wdio/globals@41

@wdio/jasmine-framework

npm i https://pkg.pr.new/gemini-testing/webdriverio/@wdio/jasmine-framework@41

@wdio/json-reporter

npm i https://pkg.pr.new/gemini-testing/webdriverio/@wdio/json-reporter@41

@wdio/junit-reporter

npm i https://pkg.pr.new/gemini-testing/webdriverio/@wdio/junit-reporter@41

@wdio/lighthouse-service

npm i https://pkg.pr.new/gemini-testing/webdriverio/@wdio/lighthouse-service@41

@wdio/local-runner

npm i https://pkg.pr.new/gemini-testing/webdriverio/@wdio/local-runner@41

@testplane/wdio-logger

npm i https://pkg.pr.new/gemini-testing/webdriverio/@testplane/wdio-logger@41

@wdio/mocha-framework

npm i https://pkg.pr.new/gemini-testing/webdriverio/@wdio/mocha-framework@41

@testplane/wdio-protocols

npm i https://pkg.pr.new/gemini-testing/webdriverio/@testplane/wdio-protocols@41

@testplane/wdio-repl

npm i https://pkg.pr.new/gemini-testing/webdriverio/@testplane/wdio-repl@41

@wdio/reporter

npm i https://pkg.pr.new/gemini-testing/webdriverio/@wdio/reporter@41

@wdio/runner

npm i https://pkg.pr.new/gemini-testing/webdriverio/@wdio/runner@41

@wdio/sauce-service

npm i https://pkg.pr.new/gemini-testing/webdriverio/@wdio/sauce-service@41

@wdio/shared-store-service

npm i https://pkg.pr.new/gemini-testing/webdriverio/@wdio/shared-store-service@41

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/gemini-testing/webdriverio/@wdio/smoke-test-cjs-service@41

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/gemini-testing/webdriverio/@wdio/smoke-test-reporter@41

@wdio/smoke-test-service

npm i https://pkg.pr.new/gemini-testing/webdriverio/@wdio/smoke-test-service@41

@wdio/spec-reporter

npm i https://pkg.pr.new/gemini-testing/webdriverio/@wdio/spec-reporter@41

@wdio/static-server-service

npm i https://pkg.pr.new/gemini-testing/webdriverio/@wdio/static-server-service@41

@wdio/sumologic-reporter

npm i https://pkg.pr.new/gemini-testing/webdriverio/@wdio/sumologic-reporter@41

@wdio/testingbot-service

npm i https://pkg.pr.new/gemini-testing/webdriverio/@wdio/testingbot-service@41

@testplane/wdio-types

npm i https://pkg.pr.new/gemini-testing/webdriverio/@testplane/wdio-types@41

@testplane/wdio-utils

npm i https://pkg.pr.new/gemini-testing/webdriverio/@testplane/wdio-utils@41

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/gemini-testing/webdriverio/@wdio/webdriver-mock-service@41

@testplane/webdriver

npm i https://pkg.pr.new/gemini-testing/webdriverio/@testplane/webdriver@41

@testplane/webdriverio

npm i https://pkg.pr.new/gemini-testing/webdriverio/@testplane/webdriverio@41

commit: c3408a4

Copy link
Copy Markdown
Member

@DudaGod DudaGod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@shadowusr shadowusr merged commit 660b5ce into master May 4, 2026
14 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants