fix: do not retry errors with code timeout from webdriver#41
Merged
fix: do not retry errors with code timeout from webdriver#41
Conversation
@testplane/devtools
eslint-plugin-wdio
@wdio/allure-reporter
@wdio/appium-service
@wdio/browser-runner
@wdio/browserstack-service
@wdio/cli
@wdio/concise-reporter
@testplane/wdio-config
@wdio/cucumber-framework
@wdio/dot-reporter
@wdio/firefox-profile-service
@wdio/globals
@wdio/jasmine-framework
@wdio/json-reporter
@wdio/junit-reporter
@wdio/lighthouse-service
@wdio/local-runner
@testplane/wdio-logger
@wdio/mocha-framework
@testplane/wdio-protocols
@testplane/wdio-repl
@wdio/reporter
@wdio/runner
@wdio/sauce-service
@wdio/shared-store-service
@wdio/smoke-test-cjs-service
@wdio/smoke-test-reporter
@wdio/smoke-test-service
@wdio/spec-reporter
@wdio/static-server-service
@wdio/sumologic-reporter
@wdio/testingbot-service
@testplane/wdio-types
@testplane/wdio-utils
@wdio/webdriver-mock-service
@testplane/webdriver
@testplane/webdriverio
commit: |
This was referenced May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's done?
Added a check to NOT retry errors with code timeout from driver.
Motivation:
What
timeoutcode means is described in the spec: https://w3c.github.io/webdriver/#dfn-timeoutIn practice, we are interested in this for navigation commands, timeouts related to: script execution, timeouts to the driver itself, etc. are not affected by this change.
My change disables timeouts specifically for a case when a driver returns the
timeoutcode, signaling it failed to complete requested operation on time.Tested on: chrome 138, firefox 145, safari 26.