test: implement browser-env tests on client-scripts#1237
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d091e30d77
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "prettier-watch": "onchange '**' --exclude-path .prettierignore -- prettier --write {{changed}}", | ||
| "test-unit": "npm run create-client-scripts-symlinks && _mocha \"test/!(integration|e2e)/**/*.js\"", | ||
| "test-unit": "_mocha \"test/!(integration|e2e|browser-env)/**/*.[jt]s\"", | ||
| "test-unit:coverage": "c8 --all --src=src --reporter=html --reporter=text-summary --exclude=\"build/**\" --exclude=\"test/**\" --exclude=\"**/*.d.ts\" _mocha \"test/!(integration|e2e)/**/*.[jt]s\"", |
There was a problem hiding this comment.
test-unit:coverage uses _mocha "test/!(integration|e2e)/**/*.[jt]s", which now matches test/browser-env/**/*.testplane.ts. Those files are browser-env specs (they use Vite-only ?raw imports and browser fixtures like browser.assertView) and are not runnable in the plain mocha/c8 unit-test process, so npm run test-unit:coverage will fail when it reaches this suite. Update the coverage glob to exclude browser-env like test-unit already does.
Useful? React with 👍 / 👎.
| uses: thollander/actions-comment-pull-request@v3 | ||
| with: | ||
| message: ${{ env.PR_COMMENT }} | ||
| comment-tag: testplane_results |
There was a problem hiding this comment.
This workflow posts PR comments with comment-tag: testplane_results, which is already used by .github/workflows/e2e.yml; when both jobs run on the same PR, they target the same tagged comment and overwrite each other’s report link/message. Give browser-env its own tag so both E2E and browser-env results remain visible.
Useful? React with 👍 / 👎.
1 participant
What's done?