feat: implement type-safe isomorphic coords helpers#1233
Open
shadowusr wants to merge 5 commits intotestplane@9from
Open
feat: implement type-safe isomorphic coords helpers#1233shadowusr wants to merge 5 commits intotestplane@9from
shadowusr wants to merge 5 commits intotestplane@9from
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 97b73c48d6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
commit: |
shadowusr
force-pushed
the
users/shadowusr/TESTPLANE-672.update-composite-image-renderer
branch
from
a0185c2 to
7202a46
Compare
❌ Testplane run failed
|
sipayRT
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's done?
Implemented a type system for type-safe coords operations.
With these, it becomes much harder to confuse numbers from different spaces or units.
These helpers are broadly used in the upcoming PRs.
For example:
leftandtopvalues without explicit type casting