fix(selectivity): dont belive in Profiler.takePreciseCoverage result#1208
Merged
KuznetsovRoman merged 2 commits intomasterfrom Feb 17, 2026
Merged
fix(selectivity): dont belive in Profiler.takePreciseCoverage result#1208KuznetsovRoman merged 2 commits intomasterfrom
KuznetsovRoman merged 2 commits intomasterfrom
Conversation
KuznetsovRoman
commented
Feb 16, 2026
| await Promise.all( | ||
| scriptIds.map(async scriptId => { | ||
| // Every "scriptId" has only one uniq "url" | ||
| const url = grouppedByScriptCoverage[scriptId][0].url; |
Member
Author
There was a problem hiding this comment.
Can be missing because of browser bug, so we don't rely on it anymore
commit: |
KuznetsovRoman
commented
Feb 17, 2026
Comment on lines
+33
to
+35
| if (!key) { | ||
| throw new Error("Attepted to check existance of cache with empty key"); | ||
| } |
Member
Author
There was a problem hiding this comment.
It is not supposed to happen anyway, but with this error message we can be sure any other errors, if occur, are not because of cache read/write for empty key
KuznetsovRoman
commented
Feb 17, 2026
| ]); | ||
| const sourceMapUrl = this._scriptIdToSourceMapUrl[scriptId]; | ||
| // Every "scriptId" has only one uniq "url" | ||
| const sourceUrl = this._scriptIdToSourceUrl[scriptId] || grouppedByScriptCoverage[scriptId][0].url; |
Member
Author
There was a problem hiding this comment.
Now we acknowledge "takePreciseCoverage" might return empty url, so we prefer getting url from "this._scriptIdToSourceUrl" - where its written by "Debugger.scriptParsed" events
sipayRT
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.