fix(selectivity): memory-leak when calculating testplane-deps#1203
Merged
KuznetsovRoman merged 1 commit intomasterfrom Feb 12, 2026
Merged
Conversation
KuznetsovRoman
commented
Feb 11, 2026
| enableCollectingTestplaneDependencies(); | ||
|
|
||
| const store = { jsTestplaneDeps: new Set<string>() }; | ||
| const store: { jsTestplaneDeps?: Set<string> } = { jsTestplaneDeps: new Set() }; |
Member
Author
There was a problem hiding this comment.
After "fn" completion, "store" is reachable in CDP ping interval callback, so it never GC-removed
commit: |
KuznetsovRoman
commented
Feb 11, 2026
|
|
||
| return testDependenciesStorage.run(store, fn); | ||
| return testDependenciesStorage.run(store, fn).finally(() => { | ||
| delete store.jsTestplaneDeps; |
Member
Author
There was a problem hiding this comment.
Thats why we do it manually.
Removing "jsTestplaneDeps" is enough, and, if someone has pointer to it, its not cleared
Member
There was a problem hiding this comment.
Probably worth leaving a comment
shadowusr
approved these changes
Feb 12, 2026
|
|
||
| return testDependenciesStorage.run(store, fn); | ||
| return testDependenciesStorage.run(store, fn).finally(() => { | ||
| delete store.jsTestplaneDeps; |
Member
There was a problem hiding this comment.
Probably worth leaving a comment
KuznetsovRoman
force-pushed
the
TESTPLANE-891.fix_testplane_selectivity_mem_leak-1
branch
2 times, most recently
from
02fa901 to
66c4ae6
Compare
KuznetsovRoman
force-pushed
the
TESTPLANE-891.fix_testplane_selectivity_mem_leak-1
branch
from
66c4ae6 to
629d790
Compare
KuznetsovRoman
deleted the
TESTPLANE-891.fix_testplane_selectivity_mem_leak-1
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.