fix: handle init selectivity error#1201
Merged
KuznetsovRoman merged 1 commit intomasterfrom Feb 12, 2026
Merged
Conversation
commit: |
KuznetsovRoman
commented
Feb 5, 2026
| await Promise.all([cssSelectivity.start(), jsSelectivity.start()]); | ||
| await Promise.allSettled([cssSelectivity.start(), jsSelectivity.start()]).then(async ([css, js]) => { | ||
| if (css.status === "rejected" || js.status === "rejected") { | ||
| await Promise.all([cssSelectivity.stop(true), jsSelectivity.stop(true)]); |
Member
Author
There was a problem hiding this comment.
Cant throw when drop=true is passed
| await Promise.all([cssSelectivity.stop(true), jsSelectivity.stop(true)]); | ||
|
|
||
| const originalError = | ||
| css.status === "rejected" ? css.reason : js.status === "rejected" ? js.reason : "unknown reason"; |
Member
Author
There was a problem hiding this comment.
"unknown reason" path is impossible, but typescript wants to be 100% sure
shadowusr
approved these changes
Feb 12, 2026
| const originalError = | ||
| css.status === "rejected" ? css.reason : js.status === "rejected" ? js.reason : "unknown reason"; | ||
|
|
||
| throw new Error(`Selectivity: Couldn't start selectivity: ${originalError}`); |
Member
There was a problem hiding this comment.
Looks like we'll lose stack and cause of original error if they are present. I'd use throw new Error('...message', {cause: originalError}) to preserve all originalError data.
Member
Author
There was a problem hiding this comment.
Will fix it in next PR in multiple places to avoid rebases
KuznetsovRoman
force-pushed
the
TESTPLANE-882.init_selectivity
branch
from
463d373 to
ded3cfc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.