Conversation
- Updated create_git_repository_link tool to check for existing repository links before attempting creation.
- If an existing link is found, it is returned with a success message instead of failing with an "already exists" error.
- Fixed a typo in the create_git_connection success message ("pre-exsisting" -> "pre-existing").
- Added a new test case TestAddDevConnectGitRepoLink_ExistingLink to verify the idempotent behavior.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces an automated evaluation framework, including a new Dockerfile, evaluation configurations, and shell scripts for deployment and validation. It also updates the cicd-mcp-server to check for existing git repository links before creation. Key feedback includes fixing an invalid Terraform version and an incorrect Gemini model name, using a stable Debian base image, and ensuring consistent return types in the MCP server tools.
alex-doudou
force-pushed
the
fix-devconnect-idempotency
branch
from
c7e5de1 to
f409845
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces idempotency checks for adding Git repository links by verifying if a link already exists before attempting to create a new one. It also corrects a typo in the connection setup tool and includes a new test case for the existing link scenario. The review feedback highlights inconsistencies in the return types between the new idempotency paths and the existing success paths, suggesting that objects be returned directly or with consistent messaging to ensure reliable client-side parsing.
Return the GitRepositoryLink directly instead of a ResultWrapper when an existing link is found, ensuring consistency with the success path.
1 participant
This PR:
create_git_repository_linktool to check for existing repository links before attempting creation.TestAddDevConnectGitRepoLink_ExistingLinkto verify the idempotent behavior.