fix: align SQL execute gutter icon to actual statement start line - #123
Merged
Conversation
The scanner's bufStart sits right after the previous `;`, so when statements are separated by blank lines or comment lines, the gutter icon was displayed on the wrong line (the blank after `;` or the comment line) instead of the first non-whitespace, non-comment line (the actual SQL keyword). Added skipLeadingComments() to count leading whitespace, `--` line comments, and `/* */` block comments, shifting the icon to the first line with actual SQL content. Includes tests for blank-line-separated and comment-separated statements. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The SQL execute gutter icon was displayed on the wrong line when statements are separated by blank lines or comment lines. For example:
The scanner's
bufStartsits right after the previous;, sostartLineNumberreflected the position of that blank/comment line instead of the first actual SQL content.Fix
Added
skipLeadingComments()function that scans leading lines and skips:--line comments/* */block commentsThe first line with actual SQL content determines the gutter icon position.
Before vs After
SELECT;)SELECT;)SELECT;)SELECTVerification