Skip to content

feat: implement typed throws#1194

Merged
vobradovich merged 8 commits intomaster-idl-v2from
feat/impl-throws-gr-panic
Mar 17, 2026
Merged

feat: implement typed throws#1194
vobradovich merged 8 commits intomaster-idl-v2from
feat/impl-throws-gr-panic

Conversation

@m62624
Copy link
Copy Markdown
Member

@m62624 m62624 commented Jan 22, 2026

Resolves #1184

@m62624 m62624 force-pushed the feat/impl-throws-gr-panic branch 2 times, most recently from 7650bdd to f3e37bc Compare January 27, 2026 05:08
@m62624 m62624 marked this pull request as ready for review January 27, 2026 08:20
@m62624 m62624 force-pushed the feat/impl-throws-gr-panic branch from f9bb5a6 to 597ab4f Compare January 29, 2026 07:37
@m62624 m62624 marked this pull request as draft January 29, 2026 11:18
@m62624 m62624 force-pushed the feat/impl-throws-gr-panic branch from f822c3b to c201919 Compare January 30, 2026 11:37
@m62624 m62624 force-pushed the feat/impl-throws-gr-panic branch from 7bf6fe4 to 549fe18 Compare February 11, 2026 07:28
@m62624 m62624 marked this pull request as ready for review March 4, 2026 05:45
@m62624 m62624 requested a review from vobradovich March 4, 2026 05:45
@m62624 m62624 force-pushed the feat/impl-throws-gr-panic branch from 178219e to 5141eb3 Compare March 16, 2026 05:29
@vobradovich vobradovich added the run-benchmarks Enables running benchmarks in CI label Mar 16, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔬 Benchmark Comparison

Benchmark Current Baseline Change Change % Status
compute 465_520_585_405 465_485_012_100 +35_573_305 +0.01%
alloc-0 595_371_472 561_979_259 +33_392_213 +5.94%
alloc-12 598_812_380 565_520_788 +33_291_592 +5.89%
alloc-143 758_639_888 725_298_850 +33_341_038 +4.60% ⚠️
alloc-986 861_640_086 828_290_220 +33_349_866 +4.03% ⚠️
alloc-10945 2_215_892_359 2_042_673_536 +173_218_823 +8.48%
alloc-46367 6_541_277_164 6_507_908_597 +33_368_567 +0.51%
alloc-121392 17_167_715_862 17_134_416_241 +33_299_621 +0.19%
alloc-317810 43_905_029_889 43_871_725_854 +33_304_035 +0.08%
counter_sync 691_562_653 665_515_676 +26_046_977 +3.91% ⚠️
counter_async 861_580_461 837_190_903 +24_389_558 +2.91% ⚠️
cross_program 2_391_902_097 2_393_184_894 -1_282_797 -0.05%
redirect 3_464_582_804 3_425_067_798 +39_515_006 +1.15% ⚠️
stack_0 796_223_380 778_805_232 +17_418_148 +2.24% ⚠️
stack_1 3_766_214_348 3_693_170_602 +73_043_746 +1.98% ⚠️
stack_5 15_687_010_110 15_391_130_019 +295_880_091 +1.92% ⚠️
stack_10 29_443_241_127 28_866_676_553 +576_564_574 +2.00% ⚠️
stack_20 65_836_730_653 64_389_067_225 +1_447_663_428 +2.25% ⚠️

Legend

  • 🚀 Significant improvement (>5% reduction)
  • 👍 Minor improvement (<5% reduction)
  • ✅ No significant change
  • ⚠️ Minor regression (<5% increase)
  • ❌ Significant regression (>5% increase)

🤖 This comment was automatically generated by the benchmark comparison workflow at 52acece.

@github-actions
Copy link
Copy Markdown
Contributor

🔬 Benchmark Comparison

Benchmark Current Baseline Change Change % Status
compute 465_520_585_405 465_485_012_100 +35_573_305 +0.01%
alloc-0 595_371_472 561_979_259 +33_392_213 +5.94%
alloc-12 598_812_380 565_520_788 +33_291_592 +5.89%
alloc-143 758_639_888 725_298_850 +33_341_038 +4.60% ⚠️
alloc-986 861_640_086 828_290_220 +33_349_866 +4.03% ⚠️
alloc-10945 2_215_892_359 2_042_673_536 +173_218_823 +8.48%
alloc-46367 6_541_277_164 6_507_908_597 +33_368_567 +0.51%
alloc-121392 17_167_715_862 17_134_416_241 +33_299_621 +0.19%
alloc-317810 43_905_029_889 43_871_725_854 +33_304_035 +0.08%
counter_sync 691_562_653 665_515_676 +26_046_977 +3.91% ⚠️
counter_async 861_580_461 837_190_903 +24_389_558 +2.91% ⚠️
cross_program 2_391_902_097 2_393_184_894 -1_282_797 -0.05%
redirect 3_464_582_804 3_425_067_798 +39_515_006 +1.15% ⚠️
stack_0 795_715_891 778_805_232 +16_910_659 +2.17% ⚠️
stack_1 3_764_184_392 3_693_170_602 +71_013_790 +1.92% ⚠️
stack_5 15_678_890_286 15_391_130_019 +287_760_267 +1.87% ⚠️
stack_10 29_427_508_968 28_866_676_553 +560_832_415 +1.94% ⚠️
stack_20 65_805_773_824 64_389_067_225 +1_416_706_599 +2.20% ⚠️

Legend

  • 🚀 Significant improvement (>5% reduction)
  • 👍 Minor improvement (<5% reduction)
  • ✅ No significant change
  • ⚠️ Minor regression (<5% increase)
  • ❌ Significant regression (>5% increase)

🤖 This comment was automatically generated by the benchmark comparison workflow at b419d35.

@github-actions
Copy link
Copy Markdown
Contributor

🔬 Benchmark Comparison

Benchmark Current Baseline Change Change % Status
compute 465_520_585_405 465_485_012_100 +35_573_305 +0.01%
alloc-0 595_371_472 561_979_259 +33_392_213 +5.94%
alloc-12 598_812_380 565_520_788 +33_291_592 +5.89%
alloc-143 758_639_888 725_298_850 +33_341_038 +4.60% ⚠️
alloc-986 861_640_086 828_290_220 +33_349_866 +4.03% ⚠️
alloc-10945 2_215_892_359 2_042_673_536 +173_218_823 +8.48%
alloc-46367 6_541_277_164 6_507_908_597 +33_368_567 +0.51%
alloc-121392 17_167_715_862 17_134_416_241 +33_299_621 +0.19%
alloc-317810 43_905_029_889 43_871_725_854 +33_304_035 +0.08%
counter_sync 691_562_653 665_515_676 +26_046_977 +3.91% ⚠️
counter_async 861_580_461 837_190_903 +24_389_558 +2.91% ⚠️
cross_program 2_391_902_097 2_393_184_894 -1_282_797 -0.05%
redirect 3_464_582_804 3_425_067_798 +39_515_006 +1.15% ⚠️
stack_0 795_715_891 778_805_232 +16_910_659 +2.17% ⚠️
stack_1 3_764_184_392 3_693_170_602 +71_013_790 +1.92% ⚠️
stack_5 15_678_890_286 15_391_130_019 +287_760_267 +1.87% ⚠️
stack_10 29_427_508_968 28_866_676_553 +560_832_415 +1.94% ⚠️
stack_20 65_805_773_824 64_389_067_225 +1_416_706_599 +2.20% ⚠️

Legend

  • 🚀 Significant improvement (>5% reduction)
  • 👍 Minor improvement (<5% reduction)
  • ✅ No significant change
  • ⚠️ Minor regression (<5% increase)
  • ❌ Significant regression (>5% increase)

🤖 This comment was automatically generated by the benchmark comparison workflow at 1b18673.

Comment thread rs/macros/core/src/service/meta.rs Outdated
@github-actions
Copy link
Copy Markdown
Contributor

🔬 Benchmark Comparison

Benchmark Current Baseline Change Change % Status
compute 465_520_585_405 465_485_012_100 +35_573_305 +0.01%
alloc-0 595_371_472 561_979_259 +33_392_213 +5.94%
alloc-12 598_812_380 565_520_788 +33_291_592 +5.89%
alloc-143 758_639_888 725_298_850 +33_341_038 +4.60% ⚠️
alloc-986 861_640_086 828_290_220 +33_349_866 +4.03% ⚠️
alloc-10945 2_215_892_359 2_042_673_536 +173_218_823 +8.48%
alloc-46367 6_541_277_164 6_507_908_597 +33_368_567 +0.51%
alloc-121392 17_167_715_862 17_134_416_241 +33_299_621 +0.19%
alloc-317810 43_905_029_889 43_871_725_854 +33_304_035 +0.08%
counter_sync 691_562_653 665_515_676 +26_046_977 +3.91% ⚠️
counter_async 861_580_461 837_190_903 +24_389_558 +2.91% ⚠️
cross_program 2_391_902_097 2_393_184_894 -1_282_797 -0.05%
redirect 3_464_582_804 3_425_067_798 +39_515_006 +1.15% ⚠️
stack_0 795_715_891 778_805_232 +16_910_659 +2.17% ⚠️
stack_1 3_764_184_392 3_693_170_602 +71_013_790 +1.92% ⚠️
stack_5 15_678_890_286 15_391_130_019 +287_760_267 +1.87% ⚠️
stack_10 29_427_508_968 28_866_676_553 +560_832_415 +1.94% ⚠️
stack_20 65_805_773_824 64_389_067_225 +1_416_706_599 +2.20% ⚠️

Legend

  • 🚀 Significant improvement (>5% reduction)
  • 👍 Minor improvement (<5% reduction)
  • ✅ No significant change
  • ⚠️ Minor regression (<5% increase)
  • ❌ Significant regression (>5% increase)

🤖 This comment was automatically generated by the benchmark comparison workflow at cdfaea7.

@vobradovich vobradovich merged commit 0f1d8c2 into master-idl-v2 Mar 17, 2026
4 checks passed
@vobradovich vobradovich deleted the feat/impl-throws-gr-panic branch March 17, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-benchmarks Enables running benchmarks in CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants