heap: partial-HOT index update improvements (phot)#37
Draft
gburd wants to merge 4 commits into
Draft
Cirrus CI / SanityCheck
failed
Jul 24, 2025 in 38s
Task Summary
Instruction build failed in 00:07
Details
✅ 00:12 clone
✅ 00:01 ccache
✅ 00:01 create_user
✅ 00:11 configure
❌ 00:07 build
[14:27:29.363] ../src/backend/access/heap/heapam.c:3466:99: warning: passing argument 3 of ‘HeapDetermineColumnsInfo’ from incompatible pointer type [-Wincompatible-pointer-types]
[14:27:29.363] 3466 | oldvals, newvals,
[14:27:29.363] | ^~~~~~~
[14:27:29.363] | |
[14:27:29.363] | Datum * {aka long unsigned int *}
[14:27:29.363] ../src/backend/access/heap/heapam.c:72:95: note: expected ‘Bitmapset *’ but argument is of type ‘Datum *’ {aka ‘long unsigned int *’}
[14:27:29.363] 72 | Bitmapset *external_cols,
[14:27:29.363] | ~~~~~~~~~~~^~~~~~~~~~~~~
[14:27:29.363] ../src/backend/access/heap/heapam.c:3466:108: warning: passing argument 4 of ‘HeapDetermineColumnsInfo’ from incompatible pointer type [-Wincompatible-pointer-types]
[14:27:29.363] 3466 | oldvals, newvals,
[14:27:29.363] | ^~~~~~~
[14:27:29.363] | |
[14:27:29.363] | Datum * {aka long unsigned int *}
[14:27:29.363] ../src/backend/access/heap/heapam.c:73:94: note: expected ‘HeapTuple’ {aka ‘HeapTupleData *’} but argument is of type ‘Datum *’ {aka ‘long unsigned int *’}
[14:27:29.363] 73 | HeapTuple oldtup, HeapTuple newtup,
[14:27:29.363] | ~~~~~~~~~~^~~~~~
[14:27:29.363] ../src/backend/access/heap/heapam.c:3467:99: warning: passing argument 5 of ‘HeapDetermineColumnsInfo’ from incompatible pointer type [-Wincompatible-pointer-types]
[14:27:29.363] 3467 | oldnulls, newnulls,
[14:27:29.363] | ^~~~~~~~
[14:27:29.363] | |
[14:27:29.363] | _Bool *
[14:27:29.363] ../src/backend/access/heap/heapam.c:73:112: note: expected ‘HeapTuple’ {aka ‘HeapTupleData *’} but argument is of type ‘_Bool *’
[14:27:29.363] 73 | HeapTuple oldtup, HeapTuple newtup,
[14:27:29.363] | ~~~~~~~~~~^~~~~~
[14:27:29.363] ../src/backend/access/heap/heapam.c:3465:34: error: too many arguments to function ‘HeapDetermineColumnsInfo’
[14:27:29.363] 3465 | modified_attrs = HeapDetermineColumnsInfo(relation, idx_attrs,
[14:27:29.363] | ^~~~~~~~~~~~~~~~~~~~~~~~
[14:27:29.363] ../src/backend/access/heap/heapam.c:70:19: note: declared here
[14:27:29.363] 70 | static Bitmapset *HeapDetermineColumnsInfo(Relation relation,
[14:27:29.363] | ^~~~~~~~~~~~~~~~~~~~~~~~
[14:27:29.363] ../src/backend/access/heap/heapam.c:3418:41: warning: unused variable ‘attridx’ [-Wunused-variable]
[14:27:29.363] 3418 | int attridx;
[14:27:29.363] | ^~~~~~~
[14:27:29.363] ../src/backend/access/heap/heapam.c:3484:9: error: ‘modified_indicies’ undeclared (first use in this function)
[14:27:29.363] 3484 | modified_indicies = HeapDetermineModifiedIncides(relation,
[14:27:29.363] | ^~~~~~~~~~~~~~~~~
[14:27:29.363] ../src/backend/access/heap/heapam.c:3484:29: warning: implicit declaration of function ‘HeapDetermineModifiedIncides’ [-Wimplicit-function-declaration]
[14:27:29.363] 3484 | modified_indicies = HeapDetermineModifiedIncides(relation,
[14:27:29.363] | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
[14:27:29.363] ../src/backend/access/heap/heapam.c:3488:107: error: ‘key_attrs_intact’ undeclared (first use in this function); did you mean ‘key_intact’?
[14:27:29.363] 3488 | &key_attrs_intact,
[14:27:29.363] | ^~~~~~~~~~~~~~~~
[14:27:29.363] | key_intact
[14:27:29.363] ../src/backend/access/heap/heapam.c: In function ‘HeapDetermineColumnsInfo’:
[14:27:29.363] ../src/backend/access/heap/heapam.c:4495:41: warning: unused variable ‘eq_op_count’ [-Wunused-variable]
[14:27:29.363] 4495 | int eq_op_count;
[14:27:29.364] | ^~~~~~~~~~~
[14:27:29.425] [440/1957] Compiling C object src/backend/postgres_lib.a.p/access_heap_rewriteheap.c.o
[14:27:29.455] [441/1957] Compiling C object src/backend/postgres_lib.a.p/access_heap_heapam_handler.c.o
[14:27:29.521] [442/1957] Compiling C object src/backend/postgres_lib.a.p/access_index_amapi.c.o
[14:27:29.526] [443/1957] Compiling C object src/backend/postgres_lib.a.p/access_index_amvalidate.c.o
[14:27:29.543] [444/1957] Compiling C object src/backend/postgres_lib.a.p/access_heap_pruneheap.c.o
[14:27:29.579] [445/1957] Compiling C object src/backend/postgres_lib.a.p/access_heap_visibilitymap.c.o
[14:27:29.761] [446/1957] Compiling C object src/backend/postgres_lib.a.p/access_heap_vacuumlazy.c.o
[14:27:29.761] ninja: build stopped: subcommand failed.
����������������������������������������������������������������������������������������������������������������������������������������������������
Loading