feat: universal 'one decision per question' AskUserQuestion rule (v0.11.12.1)#427
Merged
feat: universal 'one decision per question' AskUserQuestion rule (v0.11.12.1)#427
Conversation
Add item 5 to the shared AskUserQuestion Format in generateAskUserFormat(): "NEVER combine multiple independent decisions into a single AskUserQuestion." Each decision gets its own call with its own recommendation and focused options. Batching multiple calls in rapid succession is fine and often preferred. This promotes a rule already enforced by 3 plan-review skills (eng, ceo, design) to the universal baseline, covering all 23+ skills via the shared preamble. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
E2E Evals: ✅ PASS53/53 tests passed | $5.03 total cost | 12 parallel runners
12x ubicloud-standard-2 (Docker: pre-baked toolchain + deps) | wall clock ≈ slowest suite |
…at-a-time Resolved conflicts: - scripts/gen-skill-docs.ts: kept both sides (empty conflict at section boundary) - VERSION: bumped to 0.11.13.1 (our MICRO on top of main's 0.11.13.0) - CHANGELOG.md: added our 0.11.13.1 entry above main's 0.11.13.0 - SKILL.md files: regenerated from resolved templates via bun run gen:skill-docs Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The merge from main dropped this constant (defined in resolvers/codex-helpers.ts on main's modular version, but needed inline in our monolithic version). Caused CI check-freshness to fail on `--host codex` generation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…at-a-time Resolved conflicts: - VERSION: take main's 0.11.14.0 (newer) - CHANGELOG.md: keep main's 0.11.14.0 entry, drop our 0.11.13.1 entry (will get a fresh entry at ship time)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…at-a-time Resolved conflicts: - VERSION: take main's 0.11.16.1 (newer) - CHANGELOG.md: keep main's entries (0.11.15.0, 0.11.16.0, 0.11.16.1), drop our stale 0.11.14.1 entry (will get fresh entry at ship time)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…at-a-time Resolved conflicts: - VERSION: take main's 0.11.17.0 (newer) - CHANGELOG.md: keep main's 0.11.17.0 entry, drop our stale 0.11.16.2 entry - SKILL.md, benchmark/SKILL.md, browse/SKILL.md, setup-browser-cookies/SKILL.md: regenerated from templates via bun run gen:skill-docs
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ill-docs
The merge from main brought review/SKILL.md.tmpl with {{PLAN_COMPLETION_AUDIT_REVIEW}},
{{PLAN_COMPLETION_AUDIT_SHIP}}, and {{PLAN_VERIFICATION_EXEC}} placeholders, but the
local RESOLVERS map in the monolithic gen-skill-docs.ts didn't have entries for them.
Import the functions from scripts/resolvers/review.ts and register them.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generateAskUserFormat()inscripts/gen-skill-docs.tsTest Coverage
All new code paths have test coverage. The change is a single line of prompt text in a build-time generator — existing
gen-skill-docs.test.tsandskill-validation.test.tscover the generation pipeline.Pre-Landing Review
No issues found.
Test plan
Documentation
Documentation