fix: harden benchmark provider readiness and accounting#2283
Draft
KiDDarn wants to merge 1 commit into
Draft
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
This was referenced Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Nested Codex could wait indefinitely for additional stdin, cached input was double-counted as uncached overhead, and Gemini dry runs could claim readiness for an OAuth path that later fails with
UNSUPPORTED_CLIENT. Capacity errors were also falling into the generic unknown bucket because some CLIs report them only in the exception message.Impact
Benchmark dry runs give more accurate readiness guidance, Codex runs no longer hang on inherited stdin, token/cost reports reflect cache discounts, and temporary provider saturation is actionable instead of opaque. No live model prompts are sent by the added tests.
Validation
bin/gstack-model-benchmark --dry-run(Codex and Claude ready; stored Gemini OAuth correctly rejected; no prompts sent)npm test(exit 0)git diff --check(pass)