Skip to content

fix: honor skipped Claude skills in validation#2282

Draft
KiDDarn wants to merge 1 commit into
garrytan:mainfrom
KiDDarn:agent/fix-claude-skill-validation
Draft

fix: honor skipped Claude skills in validation#2282
KiDDarn wants to merge 1 commit into
garrytan:mainfrom
KiDDarn:agent/fix-claude-skill-validation

Conversation

@KiDDarn

@KiDDarn KiDDarn commented Jul 16, 2026

Copy link
Copy Markdown

What changed

  • make skill:check honor the Claude host's configured skipSkills list during template coverage
  • report intentionally skipped Claude-only outputs explicitly
  • fail if a skipped output unexpectedly exists
  • add a regression test for the claude/SKILL.md case

Why

The Claude generator intentionally skips the outside-voice claude skill, but the validator still required claude/SKILL.md to exist. That made skill:check report a missing generated file even when generation behaved correctly.

Impact

skill:check no longer produces a false failure for intentionally omitted Claude skills, while retaining protection against stale or unexpected generated outputs.

Validation

  • bun test test/skill-check.test.ts (pass)
  • npm test (exit 0)
  • git diff --check (pass)
  • gstack redaction scan over added lines: 0 findings

@trunk-io

trunk-io Bot commented Jul 16, 2026

Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant