Skip to content

v1.60.2.0 fix: harden Windows GBrain sync runtime#2272

Open
SatriaSuriaAriffin wants to merge 4 commits into
garrytan:mainfrom
SatriaSuriaAriffin:satria/dev-206-fix-windows-gstack-codex-runtime-packaging-and-gbrain-source
Open

v1.60.2.0 fix: harden Windows GBrain sync runtime#2272
SatriaSuriaAriffin wants to merge 4 commits into
garrytan:mainfrom
SatriaSuriaAriffin:satria/dev-206-fix-windows-gstack-codex-runtime-packaging-and-gbrain-source

Conversation

@SatriaSuriaAriffin

@SatriaSuriaAriffin SatriaSuriaAriffin commented Jul 15, 2026

Copy link
Copy Markdown

Summary

Runtime packaging

  • Include the required lib modules in both generated Codex runtime install surfaces.

Source safety

  • Normalize equivalent Windows source paths before drift decisions.
  • Preserve paths containing spaces as structural arguments and invoke resolved Windows executables directly with shell: false.
  • Fail closed for script launchers that cannot preserve argument boundaries safely.

Maintenance scope

  • Probe GBrain maintenance capabilities and refuse to widen a source-scoped request into a brain-wide cycle.

Regression coverage and documentation

  • Add compiled fake-GBrain Windows harnesses and regression cases for every reported defect.
  • Update README, usage guidance, changelog, and release metadata.

Test Coverage

All new code paths have test coverage. Tests: 90 → 92 (+2 new) after the independent coverage audit closed the final launcher and maintenance-dispatch gaps.

Focused Windows/GBrain suite: 92 passed, 0 failed, 259 expectations.

Pre-Landing Review

No issues found.

Design Review

No frontend files changed — design review skipped.

Eval Results

No prompt-related files changed — evals skipped.

Scope Drift

Scope Check: CLEAN. All changes map directly to DEV-206 implementation, regression coverage, or matching documentation and release metadata.

Plan Completion

No plan file detected. All four DEV-206 acceptance areas were independently audited as complete.

Verification Results

  • Focused Windows/GBrain suite: 92 passed, 0 failed.
  • Generated-runtime build: passed.
  • Public-repository sensitive-content scan: clean.
  • Clean upstream baseline reproduced the 28 broader Windows-suite failures unchanged, confirming they are unrelated to this diff.

TODOS

No TODO items completed in this PR.

Test plan

  • Codex runtime install and upgrade packaging includes lib.
  • Equivalent Windows paths and paths containing spaces are covered.
  • Unsafe launchers and brain-wide-only maintenance fail closed.
  • Focused regression suite and generated-runtime build pass.

Generated with OpenAI Codex

SatriaSuriaAriffin and others added 4 commits July 15, 2026 15:04
Co-Authored-By: OpenAI Codex <noreply@openai.com>
…ndows-gstack-codex-runtime-packaging-and-gbrain-source
Co-Authored-By: OpenAI Codex <noreply@openai.com>
Co-Authored-By: OpenAI Codex <noreply@openai.com>
@trunk-io

trunk-io Bot commented Jul 15, 2026

Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@SatriaSuriaAriffin

Copy link
Copy Markdown
Author

/trunk merge

@trunk-io

trunk-io Bot commented Jul 15, 2026

Copy link
Copy Markdown

An error occurred while submitting your PR to the queue: Only users that are a part of this repo's Trunk organization or have write permissions to the repo can submit a PR to the queue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant