fix(windows): add Smart App Control safe browser fallback#2265
Open
cko32002 wants to merge 1 commit into
Open
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
5 tasks
Contributor
|
@cko32002 Make the launcher discover source checkouts created by the documented Codex installation flow, and add tests for the required Windows behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
bun test test/windows-appcontrol-launcher.test.ts test/setup-windows-fallback.test.ts: 10 passed, 4 skipped, 0 failedbash -non both launchers, build script, and setup: passedScope
This is a functional fallback for Windows installations where Smart App Control blocks the unsigned Bun-compiled executable. It does not Authenticode-sign
browse.exe, and it does not close the signing and release-provenance request in #2124.The launcher is intentionally Git Bash-only, matching gstack's documented Windows runtime. No
.cmdwrapper is installed, which avoids batch metacharacter re-parsing and command-injection risk.Addresses #2124.