Skip to content

v1.61.0.0 feat: 增加有界 GitHub Codex Review 门禁#2259

Open
yangsf5 wants to merge 2 commits into
garrytan:mainfrom
yangsf5:codex/github-codex-review-gate
Open

v1.61.0.0 feat: 增加有界 GitHub Codex Review 门禁#2259
yangsf5 wants to merge 2 commits into
garrytan:mainfrom
yangsf5:codex/github-codex-review-gate

Conversation

@yangsf5

@yangsf5 yangsf5 commented Jul 14, 2026

Copy link
Copy Markdown

摘要

  • 新增 gstack-github-codex-review,支持风险评估、状态查询和有界等待。
  • 只认可 chatgpt-codex-connector[bot] 对当前 HEAD 的反馈,并通过 HEAD 标记避免重复请求。
  • 将可选门禁接入 /land-and-deploy;默认关闭,超时或 API 异常告警但不误报通过,当前 HEAD 的未解决线程会阻止合并。
  • 扩展安装侧车,使 bin/ 与共享 lib/ 在各宿主中一起分发。

测试覆盖

  • bun test test/gstack-github-codex-review.test.ts test/gen-skill-docs.test.ts:423 pass,0 fail。
  • bun run test:退出码 0。
  • bun run build:通过。
  • bash -n bin/gstack-config setup:通过。
  • git diff --check:通过。
  • 覆盖风险阈值、文档跳过、幂等请求、bot 身份、当前 HEAD、REST/GraphQL 分页、大响应管道、ACK/完成超时和阻塞语义。
  • 未执行真实付费 GitHub Codex Review E2E;该项按计划留给仓库维护者在可控额度下验证。

合并前审查

本地 diff 审查发现并已修复 3 项:多宿主硬编码路径、子进程管道死锁、非单调 deadline。最终复审无未解决问题。

计划完成

Spec 与 AutoPlan 中的实现、文档、测试和交付任务已完成;没有范围漂移。

文档

README、docs/skills.md、生成后的 land-and-deploy/SKILL.md 与 CHANGELOG 已同步。

关联事项

Closes #2258

yangsf5 and others added 2 commits July 14, 2026 13:18
新增风险判定、当前 HEAD 状态机、幂等请求、限时轮询与 land-and-deploy 接入,并覆盖分页、大响应和异常路径。
记录 GitHub Codex Review 门禁的能力、默认关闭语义与验证覆盖。

Co-Authored-By: Codex <noreply@openai.com>
@trunk-io

trunk-io Bot commented Jul 14, 2026

Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@time-attack

time-attack commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@yangsf5 Rewrite the polling loop to refetch the pull request while waiting and ensure it cannot report H1 complete after H2 becomes current.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: 为高风险 PR 增加有界 GitHub Codex Review 门禁

2 participants