Skip to content

fix: scope benchmark skill to web performance#2083

Open
creatornader wants to merge 6 commits into
garrytan:mainfrom
creatornader:fix/benchmark-skill-scope-20260622
Open

fix: scope benchmark skill to web performance#2083
creatornader wants to merge 6 commits into
garrytan:mainfrom
creatornader:fix/benchmark-skill-scope-20260622

Conversation

@creatornader

Copy link
Copy Markdown

Summary

  • rename the web performance benchmark skill to gstack-benchmark
  • narrow benchmark triggers so bare benchmark requests do not match this skill
  • add generator coverage for benchmark scope and valid llms.txt skill links

Tests

  • bun test test/gen-skill-docs.test.ts test/llms-txt-shape.test.ts

@trunk-io

trunk-io Bot commented Jun 22, 2026

Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@time-attack

Copy link
Copy Markdown
Contributor

Thanks for this. The command rename leaves active references, lacks a compatibility plan, and combines an independent link-generation repair with incomplete routing coverage. Please rebase, choose one canonical command, preserve compatibility, separate the link fix, update all references, and add real routing tests.

@creatornader
creatornader force-pushed the fix/benchmark-skill-scope-20260622 branch from de689ab to 96ecb98 Compare July 16, 2026 00:07
@creatornader

creatornader commented Jul 16, 2026

Copy link
Copy Markdown
Author

Thanks. I am addressing this review as three focused PRs:

The rename exposes the generator's invalid path assumption, so #2279 needs to land first. I will then rebase #2083 onto main and remove the copied link-repair diff from this branch. That leaves this PR limited to the command migration and its compatibility behavior.

The canonical command is /web-performance-benchmark. /benchmark and /gstack-benchmark remain compatibility aliases. I have updated the remaining active browser-design reference and added regression coverage for the canonical route. I will follow up after the rebase with the final verification rather than marking this feedback resolved early.

@creatornader

Copy link
Copy Markdown
Author

Update: the two live routing selections now pass locally. A performance-regression request invokes web-performance-benchmark, and an explicit /benchmark request resolves to the same canonical workflow.

The remaining dependency is #2279. Trunk rejected my submission from this fork because I do not have write access to the repository. Once a maintainer submits and lands #2279, I will rebase this PR onto main, remove the duplicated link repair, and post the final focused diff for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants