Skip to content

export testresults as inlined ocm-resource #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hebelsan merged 1 commit into from
Feb 10, 2026
+46 −9
Merged

export testresults as inlined ocm-resource #361

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 46 additions & 9 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,49 @@ jobs:
ocm-labels: ${{ toJSON(matrix.args.ocm-labels) }}
extra-tags: latest

sast-lint:
uses: gardener/cc-utils/.github/workflows/sastlint-ocm.yaml@master
with:
go-version: '1.25'
linter: gosec
run: .ci/verify
permissions:
contents: read

verify:
runs-on: ubuntu-latest
steps:
- uses: actions/setup-go@v5
with:
go-version: '1.25'
- uses: gardener/cc-utils/.github/actions/trusted-checkout@master
with:
remove-trusted-label: false
- uses: gardener/cc-utils/.github/actions/install-gardener-gha-libs@master
- name: run-verify
run: |
set -eu
mkdir /tmp/blobs.d
.ci/verify |& tee /tmp/blobs.d/verify-log.txt
tar czf /tmp/blobs.d/gosec-report.tar.gz gosec-report.sarif
tar czf /tmp/blobs.d/verify-log.tar.gz -C /tmp/blobs.d verify-log.txt
- name: add-reports-to-component-descriptor
uses: gardener/cc-utils/.github/actions/export-ocm-fragments@master
with:
blobs-directory: /tmp/blobs.d
ocm-resources: |
- name: gosec-report
Copy link
Copy Markdown
Contributor

@hebelsan hebelsan Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the pipeline fails because this is being handled as a list, but our provider extensions are not list-based:
https://github.com/gardener/gardener-extension-provider-openstack/blob/21c32a1f896ee14030567d753bfaff18f5fb7e18/.github/workflows/build.yaml#L137

Copy link
Copy Markdown
Contributor Author

@heldkat heldkat Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I am not so sure this is what causes the problem. This is to my knowledge the standard implementation for the component descriptor when adding more than one ocm-resource...

Copy link
Copy Markdown
Contributor Author

@heldkat heldkat Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, but now I see that the provider extension does not have an addition of test-build-logs at all yet. I will try to fix this first and see whether it resolves the issue...

Copy link
Copy Markdown
Contributor Author

@heldkat heldkat Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused. How come this change is not in the master branch although it was merged? https://github.com/gardener/gardener-extension-provider-openstack/pull/1107/changes

Copy link
Copy Markdown
Member

@AndreasBurger AndreasBurger Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused. How come this change is not in the master branch although it was merged? https://github.com/gardener/gardener-extension-provider-openstack/pull/1107/changes

Was apparently reverted by https://github.com/gardener/gardener-extension-provider-openstack/pull/1159/changes

Copy link
Copy Markdown
Contributor Author

@heldkat heldkat Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I will create a new PR.

relation: local
access:
type: localBlob
localReference: gosec-report.tar.gz
labels:
- name: gardener.cloud/purposes
value:
- lint
- sast
- gosec
- name: gardener.cloud/comment
value: |
we use gosec (linter) for SAST scans
see: https://github.com/securego/gosec
- name: test-results
relation: local
access:
type: localBlob
localReference: verify-log.tar.gz
labels:
- name: gardener.cloud/purposes
value:
- test
Loading