remove persona mapping functionality from core product#469
Merged
Conversation
Persona mapping is highly deployment-specific and was introduced for the Gardener website only. It does not belong in the generic docforge core. Remove all related logic, configuration, and tests. Relates-to: gardener#464
gardener-prow
Bot
added
do-not-merge/needs-kind
Contributor
Author
|
The CI failure is not related to the changes in this PR. The integration-test workflow requires id-token: write permission which is not available for PRs from forks — this is a GitHub security restriction. Could you please re-trigger the workflow or confirm that the failure is expected for external contributors? |
5 tasks
|
LGTM label has been added. DetailsGit tree hash: f791ba690441dfc8252318e369c35b68331d1900 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: klocke-io The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Removes persona mapping from Docforge. Persona mapping is a Gardener-specific feature that assigns content to personas (
Users,Operators,Developers) based on directory names (usage/,operations/,development/). It was introduced for the Gardener website and does not belong in the generic core — teams adopting docforge for their own pipelines encounter unexpected behavior tied to Gardener's internal documentation structure.Changes
Deleted:
pkg/manifestplugins/persona/— entire package removedpkg/nodeplugins/persona/— entire package removedcmd/persona/option.go— configuration type removeddocs/plugin/persona.md— documentation removedModified:
cmd/app/cmd.go— removedpersona.Personaimport and struct field fromoptionscmd/app/flags.go— removed--persona-filter-enabledflagcmd/app/exec.go— removed persona plugin wiring from manifest and node plugin stagestest/e2e/docforge_config.yaml— removedpersona-filter-enabledkeyWhich issue(s) this PR fixes:
Fixes #464
Special notes for your reviewer:
No behavior regressions. Verified with a full e2e run against the Gardener documentation manifest: 803 document tasks, 430 download tasks processed, exit code 0. The
--persona-filter-enabledflag now correctly returnsunknown flag.Release note: